Skip to content

Custom filter table: filter alerts are not re-validated on edit

Reproduction & observed behaviour

Case 1

  • Add a filter that triggers a warning alert in the custom filters table (for example: foo)
  • Observe the alert icon that is appended to the row
  • Edit the filter so that it is now correct and should not trigger a warning alert anymore (for example: test.com/foo).
  • → Observe that the warning alert does not disappear, unless the options page is reloaded

Case 2

  • Add a correct filter that does not trigger any warning alerts to the custom filters table (for example test.com/foo)
  • Edit the filter so that it is now incorrect and should trigger a warning alert (for example foo)
  • → Observe that the warning alert in the row does not appear until the options page is reloaded.
Expand for .gif of the issue valid-invalid-validation

Expected

Filters should be re-evaluated when changes are applied after editing. If a filter without warnings is edited in a way that is now incorrect, the alert icon should display in the row immediately after editing the filter. And vice versa- If an filter with a warning alert is corrected so that the warning is not applicable anymore, the alert should be removed immediately after the filter is edited.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information