Adding a filter that used to be disabled, is shown as enabled but still disabled

Steps to reproduce

  1. Open Advanced tab in options page
  2. Add a filter and refresh page
  3. Disable filter
  4. Refresh page
  5. Remove filter and refresh page
  6. Add the filter again
  7. Refresh page

Observed behavior

  • After 2) Filter is in list and enabled
  • After 3) Filter is in list and enabled
  • After 4) Filter is in list and disabled
  • After 5) Filter is not in list
  • After 6) Filter is in list and enabled
  • After 7) Filter is in list and disabled

Expected behavior

  • After 2) Filter is in list and enabled
  • After 3) Filter is in list and disabled
  • After 4) Filter is in list and disabled
  • After 5) Filter is not in list
  • After 6) Filter is in list and enabled
  • After 7) Filter is in list and enabled

Further information

The extension remembers which state a filter was in so we need to explicitly enable a filter whenever adding it.

Edited by Thomas Greiner
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information