Skip to content

Regression: Issue report data is incomplete

Background

We noticed that we the "filter" property is missing for <request> elements in the issue reporter data (see #133 (closed)). Upon investigating that, I wasn't able to find the part of the code which adds the requests to the report so it appears to be missing from the release-2018-4 branch.

See "requests.respond" message handler in release-2018-3.

The regression was introduced in https://gitlab.com/eyeo/adblockplus/adblockplusui/commit/c571bfe827c73bdeb283bc85d492e5428e0a830f which refactored the issue reporter code. See also https://gitlab.com/eyeo/adblockplus/adblockplusui/commit/f75282a66299ae59f75230191ac0328c837de084 where we removed the old code.

What to change

Make sure that issue report includes all data as specified.

Edited by Thomas Greiner
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information