Skip to content

Issue #210 - Handle disabled filters in downloadable subscriptions

Adilson Sandoval requested to merge issue-210 into release-2020-2

adblockpluschrome dependency changes imported from https://gitlab.com/eyeo/adblockplus/abpui/adblockpluschrome/-/merge_requests/72

This MR contains the following changes:

  • Replaced the error messages in the filter list table by a tooltip that can handle multiple errors.
  • Implemented a new error "options_filterList_filtersDisabled".
  • Provided an actionable link ("<a>Enable them</a>") that enables filters that were previously disabled, for the corresponding subscription.
  • Rename delete.svg to `close.svg and added two new views for error classes (#C70D2C, #D8566B).
  • Added new error-round icon.
  • Update UI support of "filter.disabled" event to "filterState.enabled". This should fix https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/-/issues/866.
Edited by Adilson Sandoval

Merge request reports