Skip to content

Issue 7345 - Use the extension Promise API in release-2018-5

Thomas Greiner requested to merge ThomasGreiner-eyeo/abp/ui/adblockplus:issue_7345 into release-2018-5

This MR for #352 (closed) is intended as an addition to #323 (closed) and therefore only contains the following changes:

  • Don't pass callbacks to any extension API calls that we touched on in release-2018-5.
    • Removed callback parameter from getPref() in js/desktop-options.js and updated any code that calls it to ensure that the one modified line in which we call it, is compatible with the changes introduced in #323 (closed).
  • Cleaned up lengthy callback chain in js/desktop-options.js using Promise.all().
  • Updated mock.

Merge request reports