Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • adblockplusui adblockplusui
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 235
    • Issues 235
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

GitLab 15.0 is launching on May 22! This version brings many exciting improvements, but also removes deprecated features and introduces breaking changes that may impact your workflow. To see what is being deprecated and removed, please visit Breaking changes in 15.0 and Deprecations.

  • eyeo
  • adblockplus
  • abpui
  • adblockplusuiadblockplusui
  • Issues
  • #870
Closed
Open
Created Nov 20, 2020 by Ursa Kacar@ursakacar🌴Developer

Hide social sharing option in private tabs

Background / User story

There is an option in the popup for the user to share their total number of blocked ads on social media.

It would make sense to hide that option in private tabs for multiple reasons:

  • the total number of blocked items (which is the number that is shared) is hidden in private tabs, see #851 (closed)
  • users are not logged into their accounts on private tabs
  • users probably do not want to share any information from the private tabs

For more info, see discussion in eyeo/specs/spec!358 (comment 446735053)

What to change

  • Design: n/a
  • Research: n/a
  • Spec: eyeo/specs/spec!360 (merged)
  • Legal: https://jira.eyeo.com/browse/ABPUI-48
  • Development: n/a

Hints for testers

Test that social sharing section in the popup

  • is hidden in private tabs
  • is visible and can be interacted with in regular tabs

Hints for translators

n/a

Integration notes

n/a

Edited Jan 13, 2021 by Ursa Kacar
Assignee
Assign to
Time tracking