Snippet filters not appearing in "Filters" tab in issue reports
Environment
- OS version: Windows 10 latest
- Browser version: Google Chrome 83.0.4103.116
- Extension version: 3.9
- Last working version: N/A, can be traced back to the introduction of this feature in trac#6386
Steps to reproduce
- Add custom snippet filters
example.com#$#log 'single'
andexample.com#$#log "double"
. - Go to example.com.
- Open issue reporter and follow along until the Details step.
- Click on "Click this link to review the report data before sending" link open data dialog.
Observed behavior
- Error shown in JavaScript console:
Failed to execute 'querySelector' on 'Document': '[text='example.com#$#log 'single'']' is not a valid selector.
- The following data is included in the issue report:
<requests>
<request location="http://example.com/" type="SNIPPET" docDomain="example.com" thirdParty="undefined" count="2" filter="example.com#$#log 'single'"/>
</requests>
<filters>
<filter text="example.com#$#log "double"" subscriptions="" hitCount="1"/>
</filters>
Expected behavior
- No error shown in JavaScript console.
- The following data is included in the issue report:
<requests>
<request location="http://example.com/" type="SNIPPET" docDomain="example.com" thirdParty="undefined" count="2" filter="example.com#$#log 'single'"/>
</requests>
<filters>
<filter text="example.com#$#log 'single'" subscriptions="" hitCount="1"/>
<filter text="example.com#$#log "double"" subscriptions="" hitCount="1"/>
</filters>
Further information
Due to this problem, the snippet filter is also not being shown in the Filters tab on reports.adblockplus.org, after submitting the issue report. Note that only one filter can be shown per request so the second filter is not included in <requests>
.
Edited by Thomas Greiner