Incorrect icon used to indicate whether built-in filter list is enabled
Environment
- OS version: Ubuntu 20.04
- Browser version: Chrome 83
- Extension version: UI release 2019-4
- Last working version: TBD
Steps to reproduce
- Open Advanced tab in desktop settings page.
- Click on "Add built-in filter lists" to open dropdown.
Observed behavior
Gray checkmark is shown next to "ABP Filters" filter list.
Expected behavior
Blue checkmark is shown next to "ABP Filters" filter list.
Hints for testers
- The same applies to the "Add a language" dropdown in the General tab.
- Adding a valid URL when adding a custom filter list, should continue to show a green checkmark.
Further information
There's some confusion around what the gray checkmark next indicates when it's shown next to a filter list in the built-in filter lists dropdown (see forum thread). Since the Invision design we link to from the spec, however, uses checkboxes instead of checkmarks, which are expected to require some behavioral changes, as a quick fix, we could at least apply some color to the existing checkmark to not make it appear as if the filter list may be disabled.