"rewritten to..." link in devtools pane loads inside the devtools pane on Firefox
Environment
- Browser version: Firefox 68
- Extension version: latest development build, ABP 3.5.2.2340
- Last working version: ABP 3.5
Steps to reproduce
- Add the following filter:
||testpages.adblockplus.org/testcasefiles/script$rewrite=abp-resource:blank-js,domain=testpages.adblockplus.org
- Navigate to https://testpages.adblockplus.org/en/filters/script
- Open developer tools and switch to the
Adblock Plus
panel - Reload the page so the panel is populated with requests
- Click on the rewritten url in the devtools panel (you should see
https://testpages.adblockplus.org/testcasefiles/script/script.js?3933406782 rewritten to data:application/javascript,
, the url afterrewritten to
should be clicked: see .gif below)
Observed behaviour
The blank image loads inside our developer tools pane, which means our pane goes blank.
Expected behaviour
The image should load inside a new tab instead.
Further information
- Could be related to #192 (closed)?
- If the page goes into a crazy loop reloading that's a separate issue, #510 (closed).
- Doesn't affect Chrome.
- Behaviour has changed since 3.5.2 on Firefox, for @ursakacar (Firefo 68.0.1, Ubuntu 18.04.2 LTS) the link opened in a new tab but for @kzar (Firefox 68.0.1, Debian testing) the link did nothing.
- Introduced with adblockplusui dependency update eyeo/adblockplus/adblockpluschrome@0a2d3453 or eyeo/adblockplus/adblockpluschrome@0deb3f04
Edited by Luiza Ursachi