Strings containing slash do not get added to whitelisted websites list
Environment
Unknown
Steps to reproduce
- open the bubble UI of the APB and navigate to the settings page, 'Whitelisted websites' tab
- input a string containing a slash in the input (for example:
www.test.com/something
) - click the 'add website' button
- observe that nothing happened-
test/
was not added to the list - navigate to the 'Advanced' tab
- observe that the filter
@@||test/^$document
was added to the custom filter list (NOTE! if you had no prior whitelisted websites you will have to refresh the page for the custom filterlist to show, like I had to in the gif below)
Observed behavior
The string does not get added to the list of whitelisted websites after clicking the 'add website' button. There are no errors in the console.
It does, however get added to the custom filter lists (if string was test/
the filter will be @@||test/^$document
)
I have reproduced it in both Chrome and Firefox, did not check Opera yet.
Expected behavior
-
www.test.com/something
should get added aswww.test.com
to the list of whitelisted websites - no custom filter should be added to the custom filter table
Further information
In the 'Whitelisted websites' tab of the settings page of the ABP extension, if a string in the input does not contain https://
prefix, but contains a slash (/
), it will not be added to the list after the 'add website' button is clicked. A corresponding filter in the 'Advanced' tab will get added though.
We also expect #248 (closed) to be fixed as a result of the change we made for this issue.
Edited by Thomas Greiner