Skip to content

Always provide a details object with tabId and frameId in onFilterMatch

We still have some cases in which we trigger onFilterMatch with a null details object. To make it possible to filter the filter matches belonging to a specific tab, we should always include at least tabId and frameId. (see https://gitlab.com/eyeo/adblockplus/webext-sdk/-/issues/64#note_611539884)

  • logItem in checkPotentialPopup. We already have access to a tabId, we should be able to pass a frameId from both callers of the checkPotentialPopup function.
  • logItem in applyContentFilters. The function already has a tabId and frameId parameter.