Skip to content

Replace list of servers with the DataList widget

Jaladh Singhal requested to merge jaladh-singhal/exosphere:sl-with-dl into master

Finally puts DataList widget (started in !574 (merged)) to use in ServerList page. This completely fixes #451 (closed), #306 (closed) and partially covers #101.

Other than adding new features to servers list, there are few notable changes from current design:

  • The delete button in each row is made a secondary danger button (less attention drawing) because it's not what we are inviting users to do. The primary danger button should only be on confirmation step (as per many UX guides) - that it is now, in delete popconfirm and when doing bulk selection.
  • The delete confirmation for each server is now done by a popconfirm so that other elements need not to change their position.
  • The delete icon is changed to FeatherIcon because it's outlined icon (over solid icon that would have been more attention drawing when colored red) and because it doesn't require a color parameter (but adapts to the font color coming conditionally from palette)
  • Hovering over delete button, status indicator show a tooltip by leveraging html title property i.e. commonly used on web wherever icons are used

Besides, this MR also makes DataList dark theme adaptable by using colors from palette.

There are few more things that need to be taken care of, I've created follow-up issues for them.

How to Test

Try out the new ServerList page.

Screenshots

Screenshot_from_2022-02-10_02-05-01

QA Checklist

  • Any changes to 'widgets' in src/Style/Widgets/? If so:
    • Update src/Style/StyleGuide.elm showing example usage of that widget
  • Were any app flags created, modified, or removed? If so:
    • Update config.js and all files in environment-configs/, including docker-config.js
    • Update "Runtime configuration options" documentation in README.md

Post-Merge Checklist

  • Create follow-up issues for anything left over for another merge request
    • If any technical debt is introduced, assign these follow-up issues to the MR submitter
Edited by Jaladh Singhal

Merge request reports