Skip to content

Follow-up from "First attempt at filtering by selecting image tags"

The following discussions from !282 (merged) should be addressed:

  • @cmart started a discussion: (+2 comments)

    @julianpistorius the behavior of this feature is frickin' awesome! The code is nice and clean overall. My only concerns are with the presentation, in subjective descending order of importance..

    1. I still don't think it's good to show the user a big wall o' tags by default. If I don't want to browse by tags then I need to scroll way down below the fold.

    image

    I suggested a minimal fix for this back here, there could be better solutions.

    ...

    1. This is a nitpick (as other parts of the app are nearly as ugly): the spacing between tags is all over the place.

    image

    Approving for if you prefer to merge as-is, and create follow-up issues for whatever portion of the above you agree is worth addressing.

More things:

  • Increase space between selected tags (cmart remembers something about it being related to having HTML inside an Elm UI view)
  • Don't show 'Filtering on these tags:' when there are no selected tags
  • Show selected tags in the order that they were selected