Eulyeon Ko (37d7d4ec) at 28 Mar 11:00
Update documentation for burnchart
Update documentation for burnchart
Document the new rollup weight/counting behavior.
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
Numbered steps to set up and validate the change are strongly suggested.
Related to #381879
Eulyeon Ko (277ccf15) at 28 Mar 10:58
Update documentation for burnchart
Eulyeon Ko (a2141905) at 28 Mar 10:34
WIP
milestone '16.10'
@huzaifaiftikhar1 I don't have any issue with the fix. Can you wait for a confirmation in the database maintainer's channel and then assign a maintainer?
Eulyeon Ko (dda3058b) at 28 Mar 03:41
Wip
I believe we have a dependency feature for migrations:
# This depends on the finalization of QueueBackfillRoutesNamespaceId BBM
class AddNotNullToRoutesNamespaceId < Gitlab::Database::Migration[2.1]
DEPENDENT_BATCHED_BACKGROUND_MIGRATIONS = ["20231113120650"]
def up
add_not_null_constraint :routes, :namespace_id
end
def down
remove_not_null_constraint :routes, :namespace_id
end
end
@bmarjanovic, @huzaifaiftikhar1
My capacity to help is limited. I am leaving GL next week and I have a high priority work to focus on. Could you please assign a DRI?
cc. @awinata
@bmarjanovic, @huzaifaiftikhar1, @imskr
I would definitely try to find out about the status of
UpdateDelayedProjectRemovalToNullForUserNamespaces
before removing the columns in the next release.
The finalization should've occurred prior to removing the column.
If I am reading the merge dates correctly, !144361 (merged) and !144347 (merged) must have shipped together in 16.10 leading to the issue #451760 (comment 1835259407).
Eulyeon Ko (fd57c47f) at 28 Mar 00:30
Wip
Eulyeon Ko (82019325) at 27 Mar 14:47
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
Numbered steps to set up and validate the change are strongly suggested.
Related to #381879
Eulyeon Ko (cf829eb2) at 27 Mar 11:37
Wip
Thanks both. I agree with all your refactoring suggestions. The relevant code will be removed though.
@brytannia Please see !147867 (comment 1832976211).
The updated logic's been extracted from the service https://gitlab.com/gitlab-org/gitlab/-/blob/eee0e07bef69be4261c805d280da79aa6813927e/ee/lib/gitlab/timebox/snapshot_builder.rb.