Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
See what's new at GitLab
4
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Switch to GitLab Next
Sign in / Register
Toggle navigation
widgets
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Locked Files
Issues
0
Issues
0
List
Boards
Labels
Service Desk
Milestones
Iterations
Merge Requests
0
Merge Requests
0
Requirements
Requirements
List
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Test Cases
Security & Compliance
Security & Compliance
Dependency List
License Compliance
Operations
Operations
Incidents
Environments
Packages & Registries
Packages & Registries
Package Registry
Container Registry
Analytics
Analytics
CI / CD
Code Review
Insights
Issue
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
energenious-open-source
widgets
Commits
cf45715a
Commit
cf45715a
authored
Sep 14, 2020
by
Daniele Berardo
Browse files
Options
Browse Files
Download
Plain Diff
Merge branch 'widget-sdk/fix-classname-problem' into 'development'
Classnames will properly be appended See merge request
!35
parents
b0288a12
df5cc2eb
Pipeline
#189532435
passed with stages
in 6 minutes and 28 seconds
Changes
5
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
6 additions
and
11 deletions
+6
-11
lib/package-lock.json
lib/package-lock.json
+1
-1
lib/package.json
lib/package.json
+1
-1
lib/src/embeddable-widget.tsx
lib/src/embeddable-widget.tsx
+2
-2
lib/test/embeddable-widget/rendering.test.jsx
lib/test/embeddable-widget/rendering.test.jsx
+1
-6
lib/test/util/render.jsx
lib/test/util/render.jsx
+1
-1
No files found.
lib/package-lock.json
View file @
cf45715a
{
"name": "@tecnojest/widget-base",
"version": "1.4.3
2
",
"version": "1.4.3
7
",
"lockfileVersion": 1,
"requires": true,
"dependencies": {
...
...
lib/package.json
View file @
cf45715a
{
"name"
:
"@tecnojest/widget-base"
,
"author"
:
"Tecnojest srl https://www.invidea.it"
,
"version"
:
"1.4.3
2
"
,
"version"
:
"1.4.3
7
"
,
"publishConfig"
:
{
"registry"
:
"https://npm.invidea.it"
},
...
...
lib/src/embeddable-widget.tsx
View file @
cf45715a
...
...
@@ -75,7 +75,7 @@ export default class EmbeddableWidget {
static
packageJson
:
PackageJson
=
require
(
'
../package.json
'
);
private
static
setClassName
({
props
}:
{
props
:
Props
}):
void
{
const
{
className
}
=
props
.
options
;
const
{
className
}
=
props
;
EmbeddableWidget
.
options
.
className
=
parseClassName
(
className
);
}
...
...
@@ -185,8 +185,8 @@ export default class EmbeddableWidget {
const
options
:
Options
=
{
...
EmbeddableWidget
.
INITIAL_OPTIONS
,
...
EmbeddableWidget
.
options
,
...
defaultOptionsFromProps
,
...
EmbeddableWidget
.
options
,
...
this
.
Widget
.
options
,
...
newOptions
,
};
...
...
lib/test/embeddable-widget/rendering.test.jsx
View file @
cf45715a
...
...
@@ -42,7 +42,6 @@ describe('React rendering', () => {
static
options
=
{
appendFooter
:
false
,
appendTooltip
:
false
,
className
:
'
custom
'
,
};
render
()
{
...
...
@@ -52,11 +51,7 @@ describe('React rendering', () => {
render
(
Widget
,
UID
);
const
widget
=
document
.
getElementById
(
'
widget
'
);
expect
(
widget
.
parentElement
.
className
).
toEqual
(
'
custom
'
);
expect
(
document
.
querySelector
(
'
footer
'
)).
toBeFalsy
();
expect
(
document
.
querySelector
(
'
#
widget-base-tooltip__container
'
)).
toBeFalsy
();
expect
(
document
.
querySelector
(
'
.
widget-base-tooltip__container
'
)).
toBeFalsy
();
});
});
lib/test/util/render.jsx
View file @
cf45715a
...
...
@@ -14,7 +14,7 @@ function render(Widget, uid) {
EmbeddableWidget
.
Engine
=
{
createElement
:
(
props
)
=>
{
return
<
Widget
{
...
props
}
/>;
return
<
Widget
{
...
props
}
className
=
{
process
.
env
.
WIDGET_MAIN_CSS_CLASS
}
/>;
},
render
:
(
component
,
el
)
=>
ReactDOM
.
render
(
component
,
el
),
unmountComponentAtNode
:
(
node
)
=>
ReactDOM
.
unmountComponentAtNode
(
node
),
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment