Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
E
ECL
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 182
    • Issues 182
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 6
    • Merge Requests 6
  • Requirements
    • Requirements
    • List
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • Embeddable Common-Lisp
  • ECL
  • Merge Requests
  • !20

Merged
Opened Mar 17, 2016 by E. Madison Bray@embrayContributor

Allow CC and other environment variables to contain space when building

  • Overview 1
  • Commits 1
  • Changes 1

Currently if the value of CC or the like contains a space (most notably, CC=ccache gcc) the build fails like so:

;;; Note:
;;;   Invoking external command:
;;;   ccache gcc -I. -I/home/iguananaut/src/ecl/ecl/build/ -DECL_API -I/home/iguananaut/src/ecl/ecl/build/c -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -g -O2 -fPIC -D_THREAD_SAFE -Dlinux -I/home/iguananaut/src/ecl/ecl/src/c -c lsp/export.c -o lsp/export.o exec: No such file or directory

Condition of type: SIMPLE-ERROR
Error code 6 when executing
(RUN-PROGRAM "ccache gcc" ("-I." "-I/home/iguananaut/src/ecl/ecl/build/" "-DECL_API" "-I/home/iguananaut/src/ecl/ecl/build/c" "-D_GNU_SOURCE" "-D_FILE_OFFSET_BITS=64" "-g" "-O2" "-fPIC" "-D_THREAD_SAFE" "-Dlinux" "-I/home/iguananaut/src/ecl/ecl/src/c" "-c" "lsp/export.c" "-o" "lsp/export.o"))

Available restarts:

1. (CONTINUE) Continues anyway.
2. (ABORT) ABORT

Top level in: #<process TOP-LEVEL>.

This fixes the issue generally by patching safe-run-program rather than checking for this case every time *cc*, *ld*, etc. are used.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: embeddable-common-lisp/ecl!20
Source branch: fix-generic-cc

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.