danger-review
Passed Started
by
@edith007
Siddharth Asthana
1Running with gitlab-runner 14.8.0~beta.44.g57df0d52 (57df0d52)2 on green-4.shared-gitlab-org.runners-manager.gitlab.com/default x5QiHUKw3 feature flags: FF_USE_FASTZIP:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images:debian-bullseye-ruby-2.7.patched-golang-1.16-git-2.33-lfs-2.9-chrome-97-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images:debian-bullseye-ruby-2.7.patched-golang-1.16-git-2.33-lfs-2.9-chrome-97-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 ...9Using docker image sha256:456702e6ff9a9321c3b9d1982b92a7f8e24135ed69200af2145f633cc5935ebe for registry.gitlab.com/gitlab-org/gitlab-build-images:debian-bullseye-ruby-2.7.patched-golang-1.16-git-2.33-lfs-2.9-chrome-97-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:3d4194c9cbc4c7a5bfb9057fafffe6229b3542f0994b6adb8864733d65ff1204 ...11Running on runner-x5qihukw-project-27783254-concurrent-0 via runner-x5qihukw-shared-gitlab-org-1645462793-26b7cbba...13$ eval "$CI_PRE_CLONE_SCRIPT"14Fetching changes with git depth set to 20...15Initialized empty Git repository in /builds/gitlab-org-forks/gitlab/.git/16Created fresh repository.17Checking out bcc8484f as issue_341248_show.html.haml...18Skipping Git submodules setup20Checking cache for ruby-gems-bullseye...21FATAL: file does not exist 22Failed to extract cache23Checking cache for node-modules-bullseye-test...24FATAL: file does not exist 25Failed to extract cache27Using docker image sha256:456702e6ff9a9321c3b9d1982b92a7f8e24135ed69200af2145f633cc5935ebe for registry.gitlab.com/gitlab-org/gitlab-build-images:debian-bullseye-ruby-2.7.patched-golang-1.16-git-2.33-lfs-2.9-chrome-97-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:3d4194c9cbc4c7a5bfb9057fafffe6229b3542f0994b6adb8864733d65ff1204 ...28$ source scripts/utils.sh29$ bundle_install_script "--with danger"30Successfully installed bundler-2.3.6311 gem installed32Bundler version 2.3.633production:development34Settings are listed in order of priority. The top value will be used.35clean36Set for the current user (/root/.bundle/config): true37install_flags38Set via BUNDLE_INSTALL_FLAGS: "--jobs=$(nproc) --retry=3 --quiet"39path40Set for the current user (/root/.bundle/config): "/builds/gitlab-org-forks/gitlab/vendor"41without42Set via BUNDLE_WITHOUT: [:production, :development]43$ bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check44[DEPRECATED] The `--with` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set --local with 'danger'`, and stop using this flag45Don't run Bundler as root. Bundler can ask for sudo if it is needed, and46installing your bundle as root will break this application for all non-root47users on this machine.48The Gemfile's dependencies are satisfied49==> 'bundle install --jobs=$(nproc) --retry=3 --quiet --with danger && bundle check' succeeded in 494 seconds.50$ bundle pristine pg51Installing pg 1.2.3 with native extensions52==> 'bundle pristine pg' succeeded in 12 seconds.53$ run_timed_command "retry yarn install --frozen-lockfile"54$ retry yarn install --frozen-lockfile55yarn install v1.22.1056[1/5] Validating package.json...57[2/5] Resolving packages...58[3/5] Fetching packages...59info fsevents@2.1.3: The platform "linux" is incompatible with this module.60info "fsevents@2.1.3" is an optional dependency and failed compatibility check. Excluding it from installation.61[4/5] Linking dependencies...62warning "@gitlab/eslint-plugin > eslint-plugin-jest > @typescript-eslint/experimental-utils > @typescript-eslint/typescript-estree > tsutils@3.17.1" has unmet peer dependency "typescript@>=2.8.0 || >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta".63warning "@graphql-eslint/eslint-plugin > graphql-config > @endemolshinegroup/cosmiconfig-typescript-loader > ts-node@9.1.1" has unmet peer dependency "typescript@>=2.7".64warning " > eslint-import-resolver-jest@3.0.2" has unmet peer dependency "eslint-plugin-import@>=1.4.0".65warning " > eslint-import-resolver-webpack@0.13.2" has unmet peer dependency "eslint-plugin-import@>=1.4.0".66[5/5] Building fresh packages...67$ node ./scripts/frontend/postinstall.js68success Dependency postinstall check passed.69Done in 76.11s.70==> 'retry yarn install --frozen-lockfile' succeeded in 76 seconds.71$ if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then # collapsed multi-line command72$ bundle exec danger --fail-on-errors=true --verbose73danger/ci_templates/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::TEMPLATE_MESSAGE74danger/gitaly/Dangerfile:3: warning: previous definition of TEMPLATE_MESSAGE was here75Results:76Warnings:77- [ ] This merge request contains deprecated components. Please consider using Pajamas components instead.78- [ ] You've made some app changes, but didn't add any tests.79That's OK as long as you're refactoring existing code,80but please consider adding any of the ~"type::tooling", ~"tooling::pipelines", ~"tooling::workflow", ~"documentation", ~"QA" labels.81- [ ] Please add a [merge request type](https://about.gitlab.com/handbook/engineering/metrics/#work-type-classification) to this merge request.82- [ ] This merge request does not refer to an existing milestone.83Markdown:84## Deprecated components85These deprecated components are in the process of being migrated. Please consider using [Pajamas components](https://design.gitlab.com/components/overview) instead.86* with_tooltip87## Reviewer roulette88Changes that require review have been detected!89Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:90| Category | Reviewer | Maintainer |91| -------- | -------- | ---------- |92| ~frontend | [Tristan Read](https://gitlab.com/tristan.read) (`@tristan.read`) (UTC+13) | [Vitaly Slobodin](https://gitlab.com/vitallium) (`@vitallium`) (UTC+3) |93To spread load more evenly across eligible reviewers, Danger has picked a candidate for each94review slot, based on their timezone. Feel free to95[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)96if you think someone else would be better-suited97or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.98To read more on how to use the reviewer roulette, please take a look at the99[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)100and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).101Please consider assigning a reviewer or maintainer who is a102[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.103Once you've decided who will review this merge request, assign them as a reviewer!104Danger does not automatically notify them for you.105**If needed, you can retry the [`danger-review` job](https://gitlab.com/edith007/gitlab/-/jobs/2119406167) that generated this comment.**106==> 'bundle exec danger --fail-on-errors=true --verbose' succeeded in 11 seconds.108Not uploading cache ruby-gems-bullseye due to policy109Not uploading cache node-modules-bullseye-test due to policy111Job succeeded