Skip to content

Refactoring dmscripts, a follow up to #54 and !125

Hey DT, this should hopefully be the shorter of the 2.

Refactoring

There are several bugs that have come to my attention as a result of !125 (merged) that I feel is symptom of #54.

fzf is BROKEN, would not accept unrecognized user input which broke scripts

fzf is completely unusable. fzf did not display the text if it didn't exist in stdin (!125 (merged) resolves this). In addition, several scripts just inexplicably break when using fzf for no clear reason. This is a sign, in my opinion that more testing with the menu programs is needed. Specifically fzf and rofi. If we are going to support these programs then we must have more testing done. I think in the coming weeks we can discover bugs and rewrite the broken scripts as needed

dm-hub is broken, will not run certain scripts

dm-hub is also broken. It doesn't run dm-template, don't ask why. I don't know if this only affects dm-template either. This is the error if you want to hunt it down:

./dm-hub: line 46: _scripts["${choice}"]: unbound variable

dm-bookman is confusing

dm-bookman doesn't respect $DMBROWSER and uses Firefox, Chromium and Brave history instead of bookmarks.

others

There are probably others, we can document them as we go but a lot of scripts are still fundamentally broken or questionable and are in desperate need of refactoring to conform