Commit fd0c51fa authored by David O'Toole's avatar David O'Toole

fix overstuffed dialog box after APPLY-PROPERTIES

parent 54bc047a
......@@ -292,7 +292,7 @@
(defmethod apply-properties :after ((dialog buffer-properties-dialog) buffer)
(with-slots (height width buffer-name) buffer
(resize buffer height width)
(resize buffer width height)
(rename-buffer buffer buffer-name)))
;; User dialogs:1 ends here
......
......@@ -4302,10 +4302,10 @@ See sidebar for more commands to try.
(defclass property-value-entry (expression-entry) ())
(defmethod find-tab-parent ((entry expression-entry))
(defmethod find-tab-parent ((entry property-value-entry))
(parent (parent entry)))
(defmethod find-tab-proxy ((entry expression-entry))
(defmethod find-tab-proxy ((entry property-value-entry))
(parent entry))
(defmethod draw-background ((self property-row) &key color)
......@@ -4331,13 +4331,14 @@ See sidebar for more commands to try.
(update-parent-links sheet)
(freeze sheet)))
;; (defmethod layout :after ((sheet property-sheet))
(defmethod layout :after ((sheet property-sheet))
(assert (every #'(lambda (d) (= 2 (length (inputs d)))) (inputs sheet))))
(defmethod get-property-object-pairs ((sheet property-sheet))
(mapcar #'inputs (inputs sheet)))
(defmethod get-property-entries ((sheet property-sheet))
(mapcan #'identity (get-property-object-pairs sheet)))
(apply #'append (get-property-object-pairs sheet)))
(defmethod get-property-list ((sheet property-sheet))
(mapcar #'evaluate (get-property-entries sheet)))
......@@ -4350,7 +4351,7 @@ See sidebar for more commands to try.
(setf (slot-value instance slot) value)))))
(defmethod evaluate ((sheet property-sheet))
(apply-properties sheet (instance sheet)))
(prog1 nil (apply-properties sheet (instance sheet))))
(defvar *instance* nil)
......
......@@ -4718,10 +4718,10 @@ supported compiler.
(defclass property-value-entry (expression-entry) ())
(defmethod find-tab-parent ((entry expression-entry))
(defmethod find-tab-parent ((entry property-value-entry))
(parent (parent entry)))
(defmethod find-tab-proxy ((entry expression-entry))
(defmethod find-tab-proxy ((entry property-value-entry))
(parent entry))
(defmethod draw-background ((self property-row) &key color)
......@@ -4747,13 +4747,14 @@ supported compiler.
(update-parent-links sheet)
(freeze sheet)))
;; (defmethod layout :after ((sheet property-sheet))
(defmethod layout :after ((sheet property-sheet))
(assert (every #'(lambda (d) (= 2 (length (inputs d)))) (inputs sheet))))
(defmethod get-property-object-pairs ((sheet property-sheet))
(mapcar #'inputs (inputs sheet)))
(defmethod get-property-entries ((sheet property-sheet))
(mapcan #'identity (get-property-object-pairs sheet)))
(apply #'append (get-property-object-pairs sheet)))
(defmethod get-property-list ((sheet property-sheet))
(mapcar #'evaluate (get-property-entries sheet)))
......@@ -4766,7 +4767,7 @@ supported compiler.
(setf (slot-value instance slot) value)))))
(defmethod evaluate ((sheet property-sheet))
(apply-properties sheet (instance sheet)))
(prog1 nil (apply-properties sheet (instance sheet))))
(defvar *instance* nil)
......@@ -4894,7 +4895,7 @@ supported compiler.
(defmethod apply-properties :after ((dialog buffer-properties-dialog) buffer)
(with-slots (height width buffer-name) buffer
(resize buffer height width)
(resize buffer width height)
(rename-buffer buffer buffer-name)))
#+end_src
......
* Task list
** TODO fix dialog boxes
*** DONE [#A] fix eval not happening
CLOSED: [2017-04-19 Wed 18:19]
*** TODO [#A] fix exploding dialog
*** TODO [#A] show error bubble and restore value when input incorrect
*** TODO [#A] fix BACKTAB not working
*** TODO [#A] fix halos not being in front
......@@ -679,3 +677,13 @@
:ARCHIVE_CATEGORY: tasks
:ARCHIVE_TODO: DONE
:END:
** DONE [#A] fix eval not happening
CLOSED: [2017-04-19 Wed 18:37]
:PROPERTIES:
:ARCHIVE_TIME: 2017-04-19 Wed 18:37
:ARCHIVE_FILE: ~/xelf/tasks.org
:ARCHIVE_OLPATH: Task list/fix dialog boxes
:ARCHIVE_CATEGORY: tasks
:ARCHIVE_TODO: DONE
:END:
......@@ -43,5 +43,11 @@
(trace xelf::tap)
(trace xelf::get-property-object-pairs)
(trace xelf::get-property-entries)
;; (trace xelf::resize)
;; (trace xelf::layout)
;; (trace xelf::evaluate-here)
;; (trace xelf::evaluate-expression)
;; (trace xelf::evaluate-output)
;;(trace xelf::layout)
(test-gui)
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment