Minor (and unnecessary?) change in Octavia (path to modified bulma CSS) broke all my subthemes
Took me forever to figure out what had happened.
The subtheme for Family & Home (private, Agaric, and a few others remix Bulma after variable changes so they need to override the Bulma CSS from Octavia (itself overriding Bulma theme). There's a bug that requires giving the absolute path, so don't focus on that weirdness, and we're overriding Octavia's override of the Bulma theme, which is why it's in the bulma/global
namespace, but this is what all these themes were doing in their .info.yml
files:
libraries-override:
bulma/global:
css:
base:
/themes/contrib/octavia/dist/css/bulma.css: dist/css/global.css
The problem is Octavia renamed that path from dist/css/bulma.css
to dist/css/modified-bulma.css
and so my themes silently stopped overriding anything.
(Which on a new theme can be a subtle bug! Was when i tried to figure out why it worked for the other themes that i realized that, on the next update, it would stop working for them.)
Should i change my subthemes, or can we rename modified-bulma.css
back to bulma.css
? It's clearly overriding Bulma theme's compiled Bulma CSS, Bulma is meant to be modified, we don't need the file name to explicitly say it's a modification?