1. 19 Nov, 2016 1 commit
    • Ian Stapleton Cordasco's avatar
      Skip filename pattern check for provided files · 78e8165b
      Ian Stapleton Cordasco authored
      By default, when discovering files for users, we use the filename
      patterns to determine whether or not we should check that file. However,
      when a user provides the path to a file, we should instead skip checking
      the name against the filename patterns provided.
      
      For example, in Flake8 2.6 this worked:
      
          $ flake8 bin/script.py
          $ flake8 bin/script
      
      But prior to this commit only
      
          $ flake8 bin/script.py
      
      works. This commit will skip the filename pattern check if the user
      provides the path explicitly which allows
      
          $ flake8 bin/script
      
      to work again as expected.
      
      Closes #266
      78e8165b
  2. 23 Oct, 2016 1 commit
    • Ian Stapleton Cordasco's avatar
      Handle SyntaxErrors after new-lines specially · 7998734f
      Ian Stapleton Cordasco authored
      In some cases, when we handle SyntaxErrors we need to ensure that the
      column number is correct for a 1-indexed report. In some cases, we also
      need to account for the fact that the SyntaxError has happened "after" a
      new-line. To extract and alter the row and column numbers, we've moved
      the logic to a private static method on the FileChecker object to avoid
      an overly complex method.
      
      Closes #237
      7998734f
  3. 03 Aug, 2016 1 commit
    • Ian Stapleton Cordasco's avatar
      Serialize Checkers PluginTypeManager to a dict · e14d0e63
      Ian Stapleton Cordasco authored
      It seems likely that the multiprocessing module on Windows is not
      capable of serializing an object with the structure that we have and
      preserving the attributes we dynamically set on plugins (like the
      FlakesChecker). To avoid issues like this with all plugins (although
      we have only found this on Windows with the FlakesChecker), let's try
      serializing the Checkers PluginTypeManager to a dictionary so that the
      only object that a Queue is really trying to serialize/deserialize is
      the FlakesChecker itself.
      
      Related to #179
      e14d0e63
  4. 29 Jul, 2016 1 commit
  5. 28 Jul, 2016 1 commit
    • Fabian Neundorf's avatar
      Sort reports by line and column · ad3b4869
      Fabian Neundorf authored
      Originally the reports have been sorted by column and message (without the
      error code), so it didn't order after the line number.
      
      Closes #196
      ad3b4869
  6. 27 Jul, 2016 3 commits
  7. 25 Jul, 2016 1 commit
    • Ian Stapleton Cordasco's avatar
      Handle multiline strings with '# noqa' · 299e200c
      Ian Stapleton Cordasco authored
      In Flake8 2.x we allowed people to use # noqa at the end of a multiline
      string to ignore errors inside the string (e.g., E501). Being blissfully
      ignorant of this, I never accounted for it in Flake8 3. This fixes the
      oversight and allows multiline statements to have the # noqa at the end.
      
      Closes #177
      299e200c
  8. 24 Jul, 2016 1 commit
    • Fabian Neundorf's avatar
      Support functions as file plugins too · 373eb155
      Fabian Neundorf authored
      It is possible to write plugins which are only a function. At the moment they
      are called on each line manually. This allows the function also to be called
      on each file once. It works similar to creating the class and calling `run` on
      it immediately. The plugin function needs to return a generator.
      
      This is based on the original comment in the `FileChecker.run_ast_checks`
      method, but slightly modified as the original comment would've called the
      return of the function. But the function could return the reports directly.
      373eb155
  9. 21 Jul, 2016 1 commit
    • Ian Stapleton Cordasco's avatar
      Fix up merge request 78 · a1fdb5a2
      Ian Stapleton Cordasco authored
      This simplifies the changes, reduces the scope of refactors apparently
      for refactoring's sake and ensures that the internals are reasonable.
      
      It also airs on the side of preserving information rather than
      discarding or overwriting it.
      a1fdb5a2
  10. 20 Jul, 2016 2 commits
  11. 28 Jun, 2016 1 commit
  12. 26 Jun, 2016 1 commit
  13. 25 Jun, 2016 1 commit
  14. 20 Jun, 2016 1 commit
  15. 08 Jun, 2016 3 commits
  16. 07 Jun, 2016 2 commits
  17. 06 Jun, 2016 1 commit
    • Ian Stapleton Cordasco's avatar
      Wire up last pieces to make --diff work · 59c3ba75
      Ian Stapleton Cordasco authored
      To make sure we reduce as much duplication as possible, we parse the
      diff output in our main command-line Application. That then takes
      responsibility for telling the StyleGuide about the line numbers that
      are in the diff as well as telling the file checker manager which files
      from the diff should be checked.
      59c3ba75
  18. 08 May, 2016 2 commits
    • Ian Stapleton Cordasco's avatar
      Simplify result handling · d8635bb9
      Ian Stapleton Cordasco authored
      If we start collecting the results in run_parallel *immediately* after
      starting the worker processes, we do not need another process to handle
      the results. This also allows us to store all of the results on a the
      FileChecker class and process results uniformly. This also means we can
      count the number of errors and warnings in a run and use that to exit
      appropriately (using SystemExit).
      d8635bb9
    • Ian Stapleton Cordasco's avatar
      e32476b6
  19. 05 Apr, 2016 1 commit
  20. 02 Apr, 2016 2 commits
  21. 15 Mar, 2016 9 commits
  22. 11 Mar, 2016 2 commits
  23. 05 Mar, 2016 1 commit