Editing according to static code analysis

99 jobs for fix_post_push_message in 66 minutes and 45 seconds (queued for 9 seconds)
latest
Status Job ID Name Coverage
  Prepare
passed #213570159
gitlab-org
compile-assets

00:07:44

passed #213570163
gitlab-org
retrieve-tests-metadata

00:00:23

passed #213570161
gitlab-org
setup-test-env

00:04:47

 
  Test
passed #213570179
allowed to fail
code_quality

00:14:49

passed #213570289
gitlab-org
db:check-schema-pg

00:02:36

passed #213570286
gitlab-org
db:migrate:reset-mysql

00:05:18

passed #213570284
gitlab-org
db:migrate:reset-pg

00:03:38

passed #213570299
gitlab-org
db:rollback-mysql

00:06:17

passed #213570297
gitlab-org
db:rollback-pg

00:03:51

passed #213570336
gitlab-org
db:rollback-pg-geo

00:02:46

passed #213570181
allowed to fail
dependency_scanning

00:20:45

passed #213570165
gitlab-org
docs lint

00:02:42

passed #213570277
gitlab-org
downtime_check

00:03:22

passed #213570341
gitlab-org
ee-files-location-check

00:03:50

failed #213570344
gitlab-org
ee-specific-lines-check

00:03:57

passed #213570281
gitlab-org
ee_compat_check

00:01:20

passed #213570303
gitlab-org
gitlab:setup-mysql

00:05:59

passed #213570301
gitlab-org
gitlab:setup-pg

00:04:58

passed #213570339
gitlab-org
gitlab_git_test

00:00:35

passed #213570172
gitlab-org
jest

00:16:51

passed #213570169
gitlab-org
karma

00:15:11

70.73%
passed #213570294
gitlab-org
migration:path-mysql

00:17:28

passed #213570292
gitlab-org
migration:path-pg

00:16:22

passed #213570334
gitlab-org
migration:upgrade-mysql-ce-to-ee

00:06:37

passed #213570332
gitlab-org
migration:upgrade-pg-ce-to-ee

00:05:57

passed #213570177
gitlab-org
qa-frontend-node:10

00:13:58

passed #213570176
gitlab-org
qa-frontend-node:8

00:17:46

failed #213570178
gitlab-org allowed to fail
qa-frontend-node:latest

00:01:23

passed #213570173
gitlab-org
qa:internal

00:02:52

passed #213570174
gitlab-org
qa:selectors

00:03:47

passed #213570270
gitlab-org
rspec-fast-spec-helper

00:04:25

passed #213570182
gitlab-org
rspec-pg 1/50

00:20:03

passed #213570202
gitlab-org
rspec-pg 10/50

00:14:48

passed #213570203
gitlab-org
rspec-pg 11/50

00:16:10

passed #213570204
gitlab-org
rspec-pg 12/50

00:16:12

passed #213570207
gitlab-org
rspec-pg 13/50

00:16:11

passed #213570208
gitlab-org
rspec-pg 14/50

00:15:42

passed #213570209
gitlab-org
rspec-pg 15/50

00:14:05

passed #213570211
gitlab-org
rspec-pg 16/50

00:15:15

passed #213570213
gitlab-org
rspec-pg 17/50

00:16:11

passed #213570215
gitlab-org
rspec-pg 18/50

00:15:53

passed #213570216
gitlab-org
rspec-pg 19/50

00:16:26

passed #213570184
gitlab-org
rspec-pg 2/50

00:16:21

passed #213570217
gitlab-org
rspec-pg 20/50

00:16:41

passed #213570218
gitlab-org
rspec-pg 21/50

00:16:16

failed #213570219
gitlab-org
rspec-pg 22/50

00:06:03

passed #213570220
gitlab-org
rspec-pg 23/50

00:16:17

passed #213570221
gitlab-org
rspec-pg 24/50

00:18:02

passed #213570222
gitlab-org
rspec-pg 25/50

00:15:54

passed #213570224
gitlab-org
rspec-pg 26/50

00:17:51

passed #213570227
gitlab-org
rspec-pg 27/50

00:18:43

passed #213570228
gitlab-org
rspec-pg 28/50

00:17:07

passed #213570229
gitlab-org
rspec-pg 29/50

00:16:02

passed #213570185
gitlab-org
rspec-pg 3/50

00:14:42

passed #213570230
gitlab-org
rspec-pg 30/50

00:16:14

passed #213570235
gitlab-org
rspec-pg 31/50

00:19:03

passed #213570237
gitlab-org
rspec-pg 32/50

00:16:46

passed #213570238
gitlab-org
rspec-pg 33/50

00:17:53

passed #213570241
gitlab-org
rspec-pg 34/50

00:15:29

passed #213570244
gitlab-org
rspec-pg 35/50

00:20:03

failed #213570246
gitlab-org
rspec-pg 36/50

00:03:52

passed #213570250
gitlab-org
rspec-pg 37/50

00:16:07

passed #213570251
gitlab-org
rspec-pg 38/50

00:17:12

passed #213570252
gitlab-org
rspec-pg 39/50

00:15:45

passed #213570187
gitlab-org
rspec-pg 4/50

00:14:40

passed #213570253
gitlab-org
rspec-pg 40/50

00:14:51

passed #213570254
gitlab-org
rspec-pg 41/50

00:16:12

passed #213570255
gitlab-org
rspec-pg 42/50

00:14:52

passed #213570256
gitlab-org
rspec-pg 43/50

00:17:55

passed #213570257
gitlab-org
rspec-pg 44/50

00:19:06

passed #213570258
gitlab-org
rspec-pg 45/50

00:16:23

passed #213570260
gitlab-org
rspec-pg 46/50

00:16:10

passed #213570262
gitlab-org
rspec-pg 47/50

00:16:08

passed #213570264
gitlab-org
rspec-pg 48/50

00:18:00

passed #213570266
gitlab-org
rspec-pg 49/50

00:16:48

passed #213570189
gitlab-org
rspec-pg 5/50

00:16:14

passed #213570268
gitlab-org
rspec-pg 50/50

00:15:57

passed #213570190
gitlab-org
rspec-pg 6/50

00:11:56

passed #213570197
gitlab-org
rspec-pg 7/50

00:16:09

passed #213570200
gitlab-org
rspec-pg 8/50

00:17:06

passed #213570201
gitlab-org
rspec-pg 9/50

00:16:05

failed #213570328
gitlab-org
rspec-pg geo

00:04:11

failed #213570330
gitlab-org
rspec-pg-10 geo

00:05:50

passed #213570307
gitlab-org
rspec-pg-ee 1/10

00:20:50

passed #213570326
gitlab-org
rspec-pg-ee 10/10

00:20:54

passed #213570309
gitlab-org
rspec-pg-ee 2/10

00:18:26

passed #213570312
gitlab-org
rspec-pg-ee 3/10

00:25:39

passed #213570314
gitlab-org
rspec-pg-ee 4/10

00:18:42

passed #213570316
gitlab-org
rspec-pg-ee 5/10

00:21:51

passed #213570317
gitlab-org
rspec-pg-ee 6/10

00:17:42

passed #213570320
gitlab-org
rspec-pg-ee 7/10

00:20:13

failed #213570322
gitlab-org
rspec-pg-ee 8/10

00:04:20

passed #213570324
gitlab-org
rspec-pg-ee 9/10

00:21:30

failed #213570180
allowed to fail
sast

00:33:06

failed #213570274
gitlab-org
static-analysis

00:15:47

 
  Post Test
skipped #213570350
gitlab-org
coverage
skipped #213570351
gitlab-org allowed to fail
flaky-examples-check
skipped #213570349
gitlab-org
jsdoc
skipped #213570347
gitlab-org
lint:javascript:report
 
Name Stage Failure
failed
sast Test
2019/05/16 11:44:17 Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
2019/05/16 11:44:17 Timeout when running the analyzer
Running after script...
$ date
Thu May 16 11:44:23 UTC 2019
Uploading artifacts...
WARNING: gl-sast-report.json: no matching files
ERROR: No files to upload
ERROR: Job failed: exit code 1
failed
static-analysis Test
   

11777 files inspected, 2 offenses detected


Running after script...
$ date
Thu May 16 10:49:05 UTC 2019
ERROR: Job failed: exit code 1
failed
rspec-pg 22/50 Test
knapsack/: found 5 matching files                  
rspec_flaky/: found 4 matching files

rspec_profiling/: found 1 matching files

WARNING: tmp/capybara/: no matching files
Uploading artifacts to coordinator... ok
id=213570219 responseStatus=201 Created token=28mcBm7c
Uploading artifacts...
junit_rspec.xml: found 1 matching files

Uploading artifacts to coordinator... ok
id=213570219 responseStatus=201 Created token=28mcBm7c
ERROR: Job failed: exit code 1
failed
rspec-pg-10 geo Test
knapsack/: found 4 matching files                  
rspec_flaky/: found 2 matching files

rspec_profiling/: found 1 matching files

WARNING: tmp/capybara/: no matching files
Uploading artifacts to coordinator... ok
id=213570330 responseStatus=201 Created token=pPP6RCWU
Uploading artifacts...
junit_rspec.xml: found 1 matching files

Uploading artifacts to coordinator... ok
id=213570330 responseStatus=201 Created token=pPP6RCWU
ERROR: Job failed: exit code 1
failed
rspec-pg geo Test
knapsack/: found 4 matching files                  
rspec_flaky/: found 2 matching files

rspec_profiling/: found 1 matching files

WARNING: tmp/capybara/: no matching files
Uploading artifacts to coordinator... ok
id=213570328 responseStatus=201 Created token=fT5hZt2p
Uploading artifacts...
junit_rspec.xml: found 1 matching files

Uploading artifacts to coordinator... ok
id=213570328 responseStatus=201 Created token=fT5hZt2p
ERROR: Job failed: exit code 1
failed
rspec-pg-ee 8/10 Test
knapsack/: found 5 matching files                  
rspec_flaky/: found 2 matching files

rspec_profiling/: found 1 matching files

WARNING: tmp/capybara/: no matching files
Uploading artifacts to coordinator... ok
id=213570322 responseStatus=201 Created token=qTwstkLY
Uploading artifacts...
junit_rspec.xml: found 1 matching files

Uploading artifacts to coordinator... ok
id=213570322 responseStatus=201 Created token=qTwstkLY
ERROR: Job failed: exit code 1
failed
ee-specific-lines-check Test
=> Running `git remote remove canonical-ce`
=> Running `git remote remove target-ce`

ℹ️ For more information on why, see https://gitlab.com/gitlab-org/gitlab-ee/issues/2952

Running after script...
$ date
Thu May 16 10:37:29 UTC 2019
ERROR: Job failed: exit code 1
failed
rspec-pg 36/50 Test
Uploading artifacts...
coverage/: found 5 matching files
knapsack/: found 5 matching files

rspec_flaky/: found 4 matching files

rspec_profiling/: found 1 matching files

WARNING: tmp/capybara/: no matching files
Uploading artifacts to coordinator... ok
id=213570246 responseStatus=201 Created token=zPurRUD3
Uploading artifacts...
junit_rspec.xml: found 1 matching files

Uploading artifacts to coordinator... ok
id=213570246 responseStatus=201 Created token=zPurRUD3
failed
qa-frontend-node:latest Test
gyp ERR! node -v v12.2.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
Build failed with error code: 1
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
Running after script...
$ date
Thu May 16 10:34:47 UTC 2019
ERROR: Job failed: exit code 1