Loading
Commits on Source 8
-
For improved DSN compatibility, the following keys have been added: _foreign_keys | _fk _busy_timeout | _timeout _journal_mode | _journal _synchronous | _sync _auto_vacuum | _vacuum _query_only Their values are passed as-is to exec for their respective PRAGMAs and not validated in any way. The compatibility here is intended when switching between modernc.org/sqlite and mattn/go-sqlite3, where it is handy to have higher DSN compatibility and to avoid dangerous mistakes like not having foreign keys enabled. -
Ian Chechin authoredFollow-up to the DSN shorthand keys carried over from !73: document _busy_timeout/_fk/_journal/_sync/_vacuum/_query_only in the driver DSN reference, note the fixed apply order (busy_timeout first, query_only last) at the query_only call site, and add a combined-DSN test asserting the keys coexist in a single DSN regardless of the order they appear in it.
-
Ian Chechin authored
Addresses the !134 review: - Apply _auto_vacuum before the _pragma list and the other shorthand keys. auto_vacuum only takes effect while the database is new; a _journal_mode change materialises page 1 and locks it in, so the previous order made _journal_mode=wal&_auto_vacuum=1 silently resolve to auto_vacuum=0. The "Test combined DSN" case now includes _auto_vacuum and asserts it reads back as 1, proving the fixed order. - Validate every shorthand value against the set github.com/mattn/go-sqlite3 accepts and return an error on anything else, instead of silently ignoring it, so a _synchronous or _foreign_keys typo no longer downgrades durability or drops enforcement. This also removes the DSN-injection surface these keys had, since a value is now either a known token or an error. - When a key and its alias are both present, the alias wins, matching mattn (_foreign_keys=off&_fk=on -> on). - Document the apply order, precedence, accepted values, and that only _pragma values are executed verbatim and must be trusted. - CHANGELOG entry for #134.
-
cznic authoredSupport more underscore keys in DSN (continues !73) See merge request !134 Co-Authored-By:
Claude Opus 4.8 <noreply@anthropic.com>
-
cznic authored
The v1.55.0 entry said the new mattn-compatible keys were "parsed but had no effect in prior releases". They were not parsed at all; applyQueryParams never looked at them. It also described an unrecognized value as failing "instead of being silently ignored", a contrast against an unreleased iteration of !134 rather than against v1.54.0, which would read to a user upgrading as though their DSN had previously been tolerated and ignored. Restate both breaks against the last released version: keys that were ignored now take effect (with the consequence spelled out rather than just the key named), and a value outside the accepted set now fails the connection where the same DSN previously opened successfully - e.g. a duration-style _busy_timeout=5s, which is not the integer that key requires. The latter was missing entirely and is the sharper of the two. Co-Authored-By:
-
cznic authored
dsnPick treated an empty value as absent, so "_foreign_keys=on&_fk=" fell back to the primary key and enabled foreign keys. mattn/go-sqlite3 selects between a key and its alias by presence alone and then reads that key's value, so the empty alias wins and suppresses the PRAGMA entirely. Match that: pick on presence, return the selected key's value as-is. An empty value still skips the PRAGMA at the call sites, and skips validation with it, so an empty shorthand is not an error. Co-Authored-By: -
cznic authored
applyQueryParams validated each parameter as it reached it, so a DSN whose last parameter was bad still executed every PRAGMA ahead of it before failing. PRAGMA journal_mode and auto_vacuum are persistent changes to the database file, so file:x.db?_journal_mode=wal&_synchronous=bogus failed the connection and left x.db converted to WAL regardless. A failed Open must not change the database. Split the function into a validation phase and an apply phase: everything checkable is rejected before the first c.exec. Assignments to c stay in the validation phase, since newConn closes and discards the connection when this returns an error and they cannot outlive the failure. The documented apply order is unchanged and still covered by the combined-DSN test. This predates the !134 shorthand keys - master already behaved this way for _pragma combined with a late-rejected _txlock, which is why the new test covers that case too. _pragma remains the one parameter that can still fail partway, as its values are executed verbatim and cannot be checked up front. Co-Authored-By:
-
cznic authored
Adds a v1.55.0 entry for validating every DSN parameter before applying any of them. It gets its own bullet rather than folding into the !134 paragraph because it changes behavior for parameters that have shipped for years - _txlock, _timezone, _time_format, _time_integer_format, _inttotime and _texttotime - so it concerns readers who never touch the new mattn-compatible keys. The alias-selection fix is folded into the !134 paragraph instead. v1.55.0 is not tagged, so no release ever shipped the fallback behavior and describing it as a fix would document a bug nobody could have hit. Also corrects that paragraph's closing claim that "all other existing parameters are unchanged", which the validation-order change made false: those parameters are affected in when they are validated, though not in what they accept or what they mean. Co-Authored-By: