Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
B
b
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 1
    • Merge Requests 1
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • cznic
  • b
  • Merge Requests
  • !15

Merged
Opened Mar 27, 2019 by Peter Seebach@seebs
  • Report abuse
Report abuse

Seebs/decopy

  • Overview 4
  • Commits 4
  • Changes 6

This is a quick patch to allow instrumenting copies of de objects without imposing any runtime costs (in theory) when it's not in use (the functions defined in nop_inst.go can all be inlined, so the compiler will drop them since they do nothing, and won't need to compute their arguments, and the empty embedded structs don't take up space), also a simple benchmark using it. Then there's a second patch which uses this to justify changing the way overflow is handled. The actual substantive change isn't my work, it's from Travis Turner at Pilosa.

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch "https://gitlab.com/seebs/b.git" "seebs/decopy"
git checkout -b "seebs/b-seebs/decopy" FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "seebs/b-seebs/decopy"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
1
Labels
enhancement
Assign labels
  • View project labels
Reference: cznic/b!15

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.