Fix manual Damage rolls breaking armor

Ryan Walderrequested to merge
ryanw/fix-manual-damage-ablation into dev

Intent

When rolling damage using /red Xd6 there is no ablation data source to pull ablation data from so it gets set as NaN when parsing to an int. This MR check if the ablation data is NaN then sets it to 1.

  • This is meant for a hotfix
  • This is meant for the next release (see milestone)
  • This needs more reviewers than normal; there may be controversy or high complexity
  • This intentionally introduces regressions that will be addressed later
  • There is/will be documentation changes on the wiki
  • Please do not send commits here without coordinating closely with the owner
  • This is a Build System change

Related Issues

Steps to Test

  1. Checkout/Build/Load
  2. Create Character with armor
  3. Use /red to roll some damage
  4. Apply damage to Character
  5. Chat card shows Ablation: 1
  6. Armour is ablated by 1

Merge request reports