Update validation on ISNI IDs
In #646 (closed), we introduced validation of ISNI and other IDs. ISNI IDs are validated as: https://www.isni.org/isni followed by 16 characters.
Some members have been attempting to deposit ISNI IDs in the format https://www.isni.org/ followed by 16 characters and https://isni.org/ followed by 16 characters
All of these formats of ISNI IDs as URLs resolve, e.g., https://www.isni.org/isni/0000000114559647 and https://www.isni.org/0000000114559647 and https://isni.org/isni/0000000114559647
So we should update our validation to accept all formats. There is a similar issue with updating validation for wikidata IDs in issues#1663 (closed)
How urgent
Low to moderate.
Definition of ready
-
Product owner: @SaraBowman -
Tech lead: -
Service:: or C:: label applied -
Definition of done updated -
Acceptance testing plan: -
Weight applied
Definition of done
-
Unit tests identified, implemented, and passing -
SONAR on merge request branch checked by tech lead -
SONAR on merge request branch checked by reviewer -
Code reviewed -
Available for acceptance testing via a staging URL, or otherwise -
Consider any impacts to current or future architecture/infrastructure, and update specifications and documentation as needed -
Knowledge base reviewed and updated -
Public documentation reviewed and updated -
Acceptance criteria met -
System check validates ISNI as having pattern https://www.isni.org/isni/ OR https://www.isni.org/ OR https://isni.org/isni/ OR https://isni.org/ followed by 16 characters, the last of which is a check character (see example valid/invalid ISNIs above)
-
-
Acceptance testing passed -
Deployed to production
Prior to and during Backlog Refinement, consider the potential impacts this user story may have on the following areas:
- Billing/costs
- Internal documentation
- External documentation
- Schema
- Outputs
- Operations
- Support & Membership experience
- Outreach & Communications
- Testing
- Internationalization
- Accessibility
- Metrics, analytics, reporting
Additional details about the above items can be found here.