Fetching and parsing of blocked-orcid-claims.csv doesn't always succeed, causing errors
Invalid entries in this file cause errors in CS, logged to Sentry. Where an invalid entry is made, the ORCID doesn't get blocked. We can avoid this by carefully checking the file before uploading. We could add some validation if this becomes too much of a burden.
The recent ones are all caused by two errors, but they repeat every attempt.
e.g.
line 133
unable to read record: record-number=133; source=https://gitlab.com/crossref/rules/raw/master/blocked-orcid-claims.csv
line 153
invalid ORCID iD: orcid=10.1101/2020.02.26.967133; record-number=153; source=https://gitlab.com/crossref/rules/raw/master/blocked-orcid-claims.csv invalid ORCID iD: orcid={0}; record-number={1}; source={2} RoundtripException RescindedClaimsCsvReader.java read org.crossref.xs.orcidroundtrip.RescindedClaimsCsvReader in read
Background
Observed behavior
Expected behavior
How urgent
Definition of ready
-
Product owner: @bvickery1 -
Tech lead: -
Service:: or C:: label applied -
Definition of done updated -
Acceptance testing plan: -
Weight applied
Definition of done
-
Unit tests identified, implemented, and passing -
Code reviewed -
Available for acceptance testing via a staging URL, or otherwise -
Consider any impacts to current or future architecture/infrastructure, and update specifications and documentation as needed -
Knowledge base reviewed and updated -
Public documentation reviewed and updated -
Acceptance criteria met -
AC 1 -
AC 2
-
-
Acceptance testing passed -
Deployed to production
Notes
Edited by Patrick Polischuk