4.0.1 Patches,

What does this MR do and why?

• Remove no-else-* pylint exemptions and tidy code.
  
• Make unRAID more readable, and flatten path to lower, to fit standard practice
  
• Fix support log deletion race issue, where logs would be deleted before download
  
• Flatten all instances of username creation or editing, usernames should be lower case.
  
• Fix Java Pathing issues on windows, crafty would loose process as JRE would exec itself into a new PID
  because the excecution path java would not match the full path in registry.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• Have you checked this doesn't interfere/conflict/duplicate someone elses work?
• Have you fully tested your changes?
• Have you resolved any lint issues?
• Have you assigned a reviewer?
• Have you applied correct labels?

app/classes/shared/helpers.py

+import contextlib
 import os
 import re
+import winreg
 import sys
 import json
 import tempfile
@@ -93,16 +95,50 @@ class Helpers:
         if Helpers.check_file_exists(file):
             file_time = os.path.getmtime(file)
             # Check against 24 hours
-            if (time.time() - file_time) / 3600 > 24 * days:
-                return True
-            else:
-                return False
+            return (time.time() - file_time) / 3600 > 24 * days
         logger.error(f"{file} does not exist")
         return True
 
     def get_servers_root_dir(self):
         return self.servers_dir
 
+    @staticmethod
+    def which_java():
+        # Adapted from LeeKamentsky >>>
+        # https://github.com/LeeKamentsky/python-javabridge/blob/master/javabridge/locate.py
+        jdk_key_paths = (
+            "SOFTWARE\\JavaSoft\\JDK",
+            "SOFTWARE\\JavaSoft\\Java Development Kit",
+        )
+        for jdk_key_path in jdk_key_paths:
+            try:
+                with winreg.OpenKey(winreg.HKEY_LOCAL_MACHINE, jdk_key_path) as kjdk:
+                    kjdk_values = (
+                        dict(  # pylint: disable=consider-using-dict-comprehension
+                            [
+                                winreg.EnumValue(kjdk, i)[:2]
+                                for i in range(winreg.QueryInfoKey(kjdk)[1])
+                            ]
+                        )
+                    )
+                    current_version = kjdk_values["CurrentVersion"]
+                    kjdk_current = winreg.OpenKey(
+                        winreg.HKEY_LOCAL_MACHINE, jdk_key_path + "\\" + current_version
+                    )
+                    kjdk_current_values = (
+                        dict(  # pylint: disable=consider-using-dict-comprehension
+                            [
+                                winreg.EnumValue(kjdk_current, i)[:2]
+                                for i in range(winreg.QueryInfoKey(kjdk_current)[1])
+                            ]
+                        )
+                    )
+                    return kjdk_current_values["JavaHome"]
+            except WindowsError as e:  # pylint: disable=E0602
+                if e.errno == 2:
+                    continue
+                raise
+
     @staticmethod
     def check_internet():
         try:
@@ -125,10 +161,7 @@ class Helpers:
 
         a_socket.close()
 
-        if result_of_check == 0:
-            return True
-        else:
-            return False
+        return result_of_check == 0
 
     @staticmethod
     def check_server_conn(server_port):
@@ -140,10 +173,7 @@ class Helpers:
         result_of_check = a_socket.connect_ex(location)
         a_socket.close()
 
-        if result_of_check == 0:
-            return True
-        else:
-            return False
+        return result_of_check == 0
 
     @staticmethod
     def cmdparse(cmd_in):
@@ -163,7 +193,6 @@ class Helpers:
                 # Continue the loop.
                 if char == " ":
                     continue
-                else:
                 cmd_index += 1
                 cmd_out.append("")
                 new_param = False
@@ -348,7 +377,6 @@ class Helpers:
         common_path = pathlib.Path(os.path.commonpath([base, fileabs]))
         if base == common_path:
             return fileabs
-        else:
         raise ValueError("Path traversal detected")
 
     @staticmethod
@@ -405,15 +433,8 @@ class Helpers:
     @staticmethod
     def check_root():
         if Helpers.is_os_windows():
-            if ctypes.windll.shell32.IsUserAnAdmin() == 1:
-                return True
-            else:
-                return False
-        else:
-            if os.geteuid() == 0:
-                return True
-            else:
-                return False
+            return ctypes.windll.shell32.IsUserAnAdmin() == 1
+        return os.geteuid() == 0
 
     @staticmethod
     def unzip_file(zip_path):
@@ -491,9 +512,10 @@ class Helpers:
 
         # del any old session.lock file as this is a new session
         try:
+            with contextlib.suppress(FileNotFoundError):
                 os.remove(session_log_file)
         except Exception as e:
-            logger.error(f"Deleting Session.lock failed with error: {e}")
+            Console.error(f"Deleting logs/session.log failed with error: {e}")
 
     @staticmethod
     def get_time_as_string():
@@ -529,7 +551,6 @@ class Helpers:
         if os.path.exists(path) and os.path.isfile(path):
             logger.debug(f"Found path: {path}")
             return True
-        else:
         return False
 
     @staticmethod
@@ -551,7 +572,6 @@ class Helpers:
         if os.path.exists(path):
             logger.debug(f"Found path: {path}")
             return True
-        else:
         return False
 
     @staticmethod
@@ -768,10 +788,7 @@ class Helpers:
 
     @staticmethod
     def is_os_windows():
-        if os.name == "nt":
-            return True
-        else:
-            return False
+        return os.name == "nt"
 
     @staticmethod
     def wtol_path(w_path):
@@ -946,7 +963,6 @@ class Helpers:
                 # extracts archive to temp directory
                 zip_ref.extractall(temp_dir)
             return temp_dir
-        else:
         return False
 
     @staticmethod