GitLab

https://gitlab.com/costlocker/integrations/-/jobs/439775610 - stucked job
https://gitlab.com/costlocker/integrations/-/jobs/304472497 - it should not be more than 10 minutes

Probably caused by new dind image
https://gitlab.com/gitlab-com/support-forum/issues/5194#note_288435048

CzechHolidays changed, I need rebuild reports images after !47

https://gitlab.com/costlocker/integrations/-/jobs/439758562
https://costlocker.gitlab.io/-/integrations/-/jobs/439758562/artifacts/reports/backend/var/QA/security-checker.html
composer require symfony/http-foundation:~3.4 symfony/http-kernel:~3.4

One month can contain tracking from multiple recurring instances. It's not always first project.

Delete them via API or DB in Costlocker, if it's required.
(it might not be so simple for finished timesheet projects)

Created basecamp project is useless, if only admin can access it.
It's not breaking change for existing companies, otherwise we should introduce new setting.

SELECT
  settings::json->>'isCreatingBasecampProjectEnabled' AS isCreatingBasecampProjectEnabled,
  settings::json->>'areTodosEnabled' AS areTodosEnabled,
  (settings::json->>'isCreatingBasecampProjectEnabled')::bool AND NOT (settings::json->>'areTodosEnabled')::bool AS isBreakingChange,
  *
FROM cl_companies
WHERE settings IS NOT NULL;

It's hotfix. Full solution would have to:
- know about granted people in changelog/events (updated project always "No change after user request sync" at the moment)
- maybe support revoking people (current revoke is tied to people in todolists)

339aa181...2951b7a4

Basecamp - fix building simple api url without removing support for absolute urls (used for webhook)

f149623e

Missing domain in 0ac047a6
{
        "exception": "GuzzleHttp\\Exception\\RequestException",
        "error": "cURL error 3: <url> malformed (see http:\/\/curl.haxx.se\/libcurl\/c\/libcurl-errors.html)"
}

Not fully fixed in 937dd33f

/api-public/v2/v1
{
        "Simple_Activities": {}
}
{
        "errors": [{
                "status": 404,
                "title": "Resource not found",
                "detail": "Resource 'v1' is not allowed, allowed resources: '/', '/me', '/me/tokens', '/me/tokens/{id}', '/projects', '/projects/{id}', '/timeentries', '/people', '/overheads', '/webhooks', '/webhooks/{id}', '/webhooks/{id}/test'"
        }]
}

https://gitlab.com/costlocker/integrations/-/jobs/309775911
https://gitlab.com/costlocker/integrations/-/jobs/309782816
Previously I ran bin/qa in pm folder...

Otherwise number of projects don't match in Projects vs Accounts

https://github.com/basecamp/bcx-api/blob/master/sections/accesses.md#grant-access
API always returns 204, but access granted only if email_addresses is array (not object).
$emails = [
    "John Doe ([email protected])": "[email protected]"
];

Granting access to existing people was never used in production code, used only in remote test
https://gitlab.com/costlocker/integrations/blob/fd285140/basecamp/backend/src/Sync/Synchronizer.php#L189
https://gitlab.com/costlocker/app-v2/backend/commit/b8f3980

61fcd237

!44

Side-effect in array.splice (https://stackoverflow.com/q/8495687), missing React key.

c46392f8

// this works only if person has no tasks
'nonbillable' => max(0, $cost['hrs_tracked'] - $cost['hrs_billable']),

Basecamp API returns string
- Unknown Basecamp ID (probably expired basecamp)
- This Basecamp ID rekeyed its deadbolt (changed password: https://groups.google.com/forum/#!topic/37signals-api/AxpfEiNG6vk)

Argument 1 passed to League\OAuth2\Client\Provider\AbstractProvider::prepareAccessTokenResponse() must be of the type array, string given, called in /app/backend/vendor/league/oauth2-client/src/Provider/AbstractProvider.php on line 529

Fixed in 2.3.1
https://github.com/thephpleague/oauth2-client/releases/tag/2.3.1
https://github.com/thephpleague/oauth2-client/commit/9297f3bae37b8d7bdb876a0879cc3839ccc211b7#diff-58d25fe37b0dacc76bd6b7373506e480

Symfony\Component\Debug\Exception\ContextErrorException:
Warning: Invalid argument supplied for foreach()
/basecamp/backend/src/Sync/Synchronizer.php:95

It happened during processing newly created project
"meta":{"events":{"projects.create":1}}

Reproduced in tests if `"items": null`

https://github.com/costlocker/costlocker.github.io/commit/d306f41

1bd27319
https://www.redmine.org/projects/redmine/wiki/Rest_TimeEntries#Showing-a-time-entry

Test parsing xml and integration tests don't have extra value
c8e9045e