Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Snippets
  • Sign up now
  • Login
  • Sign in / Register
  • E eZ Platform Content-Aware Custom Tags
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Contextual CodeContextual Code
  • eZ Platform Content-Aware Custom Tags
  • Merge requests
  • !1

filter custom tags without core files override

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ivan Ternovtsiy requested to merge no-override into master Oct 01, 2020
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 4

I found that base-richtext.js is missing latest fixes merged into core. So, I would like to make this work without overriding core files, to prevent such issues in future.

The only part I'm not sure about is

this.customTags = Object.keys(eZ.richText.customTags).filter(this.isEnabled).filter((key) => !eZ.richText.customTags[key].isInline);
this.inlineCustomTags = Object.keys(eZ.richText.customTags).filter(this.isEnabled).filter((key) => eZ.richText.customTags[key].isInline);

I didn't cover this, but I see it works fine without this change.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: no-override