Skip to content

Consolidate or differentiate make_components and _make_components

shocklets.py has two functions with nearly identical names, where make_components calls _make_components. There are a number of possible solutions that could clear this up:

  • Change the name of _make_components to make its role more clear
  • Change the name of make_components to indicate that it is using the components made by _make_components to accomplish a task.
  • Inline _make_components in make_components