Commit 0ea75468 authored by Chris Graham's avatar Chris Graham
Browse files

Fixed MANTIS-4358 (Better handling of incorrect usernames)

parent f203b2c8

adminzone/pages/modules/admin_cns_groups.php

+1 −1
Original line number Diff line number Diff line
@@ -605,7 +605,7 @@ class Module_admin_cns_groups extends Standard_crud_module 
        $_group_leader = post_param_string('group_leader', '');

        if ($_group_leader != '') {

            $group_leader = $GLOBALS['FORUM_DRIVER']->get_member_from_username($_group_leader);

            if (is_null($group_leader)) {

            if (($group_leader === null) || (is_guest($group_leader))) {

                warn_exit(do_lang_tempcode('_MEMBER_NO_EXIST', escape_html($_group_leader)));

            }

        } else {

adminzone/pages/modules/admin_cns_merge_members.php

+0 −4
Original line number Diff line number Diff line
@@ -164,10 +164,6 @@ class Module_admin_cns_merge_members 
        $from_username = post_param_string('from');

        $from_id = $GLOBALS['FORUM_DRIVER']->get_member_from_username($from_username);



        if (is_guest($from_id)) {

            warn_exit(do_lang_tempcode('INTERNAL_ERROR'));

        }



        if ((is_null($from_id)) || (is_guest($from_id))) {

            warn_exit(do_lang_tempcode('_MEMBER_NO_EXIST', escape_html($from_username)));

        }

adminzone/pages/modules/admin_ecommerce_logs.php

+2 −2
Original line number Diff line number Diff line
@@ -463,7 +463,7 @@ class Module_admin_ecommerce_logs 
                $username = post_param_string('username', '');

                if ($username != '') {

                    $_member_id = $GLOBALS['FORUM_DRIVER']->get_member_from_username($username);

                    if (!is_null($_member_id)) {

                    if (($_member_id !== null) && (!is_guest($_member_id))) {

                        $member_id = $_member_id;

                    }

                }
@@ -498,7 +498,7 @@ class Module_admin_ecommerce_logs 
                $username = post_param_string('username', '');

                if ($username != '') {

                    $_member_id = $GLOBALS['FORUM_DRIVER']->get_member_from_username($username);

                    if (!is_null($_member_id)) {

                    if (($_member_id !== null) && (!is_guest($_member_id))) {

                        $member_id = $_member_id;

                    }

                }

adminzone/pages/modules/admin_invoices.php

+1 −1
Original line number Diff line number Diff line
@@ -241,7 +241,7 @@ class Module_admin_invoices 


        $to = post_param_string('to');

        $member_id = $GLOBALS['FORUM_DRIVER']->get_member_from_username($to);

        if (is_null($member_id)) {

        if (($member_id === null) || (is_guest($member_id))) {

            warn_exit(do_lang_tempcode('_MEMBER_NO_EXIST', escape_html($to)));

        }

adminzone/pages/modules_custom/admin_customers.php

+3 −0
Original line number Diff line number Diff line
@@ -733,6 +733,9 @@ class Module_admin_customers 
    {

        $username = post_param_string('member_username');

        $member_id = $GLOBALS['FORUM_DRIVER']->get_member_from_username($username);

        if (($member_id === null) || (is_guest($member_id))) {

            warn_exit(do_lang_tempcode('_MEMBER_NO_EXIST', escape_html($username)));

        }

        $amount = post_param_integer('amount');



        require_code('mantis');