Commit 0a016fe9 authored by Chris Graham's avatar Chris Graham
Browse files

Fixed MANTIS-3980 (Potential issues in Oracle and SQL Server DB drivers)

parent 514cd0f1

sources/database/oracle.php

+1 −1
Original line number Diff line number Diff line
@@ -472,7 +472,7 @@ class Database_Static_oracle 
    {

        $this->apply_sql_limit_clause($query, $max, $start);



        $stmt = ociparse($db, $query, 0);

        $stmt = ociparse($db, $query);

        $results = @ociexecute($stmt);

        if ((($results === false) || (((strtoupper(substr(ltrim($query), 0, 7)) == 'SELECT ') || (strtoupper(substr(ltrim($query), 0, 8)) == '(SELECT ')) && ($results === true))) && (!$fail_ok)) {

            $err = ocierror($db);

sources/database/sqlserver.php

+2 −2
Original line number Diff line number Diff line
@@ -187,7 +187,7 @@ class Database_Static_sqlserver extends Database_super_sqlserver 
     */

    public function db_start_transaction($db)

    {

        sqlsrv_begin_transaction($db, false);

        sqlsrv_begin_transaction($db);

    }



    /**
@@ -197,6 +197,6 @@ class Database_Static_sqlserver extends Database_super_sqlserver 
     */

    public function db_end_transaction($db)

    {

        sqlsrv_commit($db, true);

        sqlsrv_commit($db);

    }

}