Skip to content

Fix twitter profile photo import bug

Souradip Mookerjee requested to merge souramoo/commento:patch-1 into master

The current implementation of the twitter profile image fetching results in a broken image bug. This occurs on both self-hosted Commento instances as well as Commento.io (https://demo.commento.io)

Fixes #323 (closed)

This is because, although the photo URL is correctly retrieved from twitter and stored, when trying to display the photo an extra ?size=normal is added.

This breaks the image because Twitter rejects the URL.

See: http://pbs.twimg.com/profile_images/1260286298239139854/2p_o7quE_normal.jpg (my photo) vs http://pbs.twimg.com/profile_images/1260286298239139854/2p_o7quE_normal.jpg?size=normal (no response)

Twitter API: https://developer.twitter.com/en/docs/accounts-and-users/user-profile-images-and-banners - the normal sized image is the one returned by default.

Edited by Souradip Mookerjee

Merge request reports