Skip to content
Snippets Groups Projects

De-hack the bazel plugins

Merged Tom Coldrick requested to merge coldtom/improve-plugins into master

Massively reduces the complexity of the BazelElement by subclassing from BuildElement, we can do this now as we don't need to allow access to the network in the sandbox, thanks to.... the new BazelSource plugin. This plugin imports a generated starlark file as a python module, as we can count on the repository resolved file to be compatible with python. This hack means that we don't have to do any nasty dependency resolution ourselves, and don't need to handle bazel's tendency to creating a pile of symlinks which we need to fix up manually. This also eliminates the need for host bazel, if such a file is given, although we do have an additional dependency on the requests python module.

Note that this version of the BuildElement is dependent upon https://gitlab.com/buildstream/buildstream/merge_requests/1694 being merged

Edited by Tom Coldrick

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading