Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Clickable
Clickable
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 24
    • Issues 24
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 2
    • Merge requests 2
  • Requirements
    • Requirements
    • List
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Clickable
  • ClickableClickable
  • Merge requests
  • !209

Merged
Created Jan 25, 2020 by Jonatan Hatakeyama Zeidler@jonniusDeveloper

Don't override the architecture field in manifest without checking

  • Overview 7
  • Commits 2
  • Pipelines 5
  • Changes 3

No builder should simply override the any manifest fields. This results in weird issues similar to ubports/apps/calendar-app#187 (closed). One can set e.g. architecture field in manifest to @CLICK_ARCH@ to set it automatically. If it is set to something incorrect, this is a mistake that should be rejected.

Solves #181

Edited Mar 22, 2021 by Jonatan Hatakeyama Zeidler
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: pure-qmake-cmake