Skip to content
Snippets Groups Projects

Change NO_CCS label to only need 1 commit with CCs.

Closed Don Zickus requested to merge dzickusrh/kernel-webhooks:no_ccs_fixes into main
1 unresolved thread

While updating CONFIG requests for ARK, it was noticed the WebUI added patches did not have CCs in their changelog. This was expected as the resulting new commit would be squashed later.

This falsely generated a 'NO_CCS' label. This makes it difficult to determine which CONFIG patches really are missing maintainers.

Change the algorithm from requiring every commit in the MR to have a CC to requiring only one commit.

Add a test to check for this.

Signed-off-by: Don Zickus dzickus@redhat.com

Merge request reports

Merged results pipeline #233891445 passed

Merged results pipeline passed for b58f599a

Test coverage 79.43% (0.11%) from 1 job
Approved by
Test summary results are being parsed

Closed by Patrick TalbertPatrick Talbert 4 years ago (Jan 12, 2021 9:58am UTC)

Merge details

  • The changes were not merged into main.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
97 97 "new_path"
98 98 ].startswith(config_dir):
99 99 labels.append(CONFIG_LABEL)
100 found_cc = False
100 101 for commit in gl_mergerequest.commits():
101 if not commit.message or 'Cc: ' not in commit.message:
102 labels.append(NO_CCS_LABEL)
102 if commit.message and 'Cc: ' in commit.message:
103 found_cc = True
104 break
105 if gl_mergerequest.description and \
106 'Cc: ' in gl_mergerequest.description:
  • This MR should be obsoleted by !147 (merged).

  • Please register or sign in to reply
    Loading