Commit 380e99fc authored by Ezequiel Garcia's avatar Ezequiel Garcia Committed by Linus Torvalds

cx25821: Remove bad strcpy to read-only char*

The strcpy was being used to set the name of the board.  Since the
destination char* was read-only and the name is set statically at
compile time; this was both wrong and redundant.

The type of char* is changed to const char* to prevent future errors.
Reported-by: 's avatarRadek Masin <radek@masin.eu>
Signed-off-by: 's avatarEzequiel Garcia <elezegarcia@gmail.com>
[ Taking directly due to vacations   - Linus ]
Signed-off-by: 's avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 8a7298b7
...@@ -904,9 +904,6 @@ static int cx25821_dev_setup(struct cx25821_dev *dev) ...@@ -904,9 +904,6 @@ static int cx25821_dev_setup(struct cx25821_dev *dev)
list_add_tail(&dev->devlist, &cx25821_devlist); list_add_tail(&dev->devlist, &cx25821_devlist);
mutex_unlock(&cx25821_devlist_mutex); mutex_unlock(&cx25821_devlist_mutex);
strcpy(cx25821_boards[UNKNOWN_BOARD].name, "unknown");
strcpy(cx25821_boards[CX25821_BOARD].name, "cx25821");
if (dev->pci->device != 0x8210) { if (dev->pci->device != 0x8210) {
pr_info("%s(): Exiting. Incorrect Hardware device = 0x%02x\n", pr_info("%s(): Exiting. Incorrect Hardware device = 0x%02x\n",
__func__, dev->pci->device); __func__, dev->pci->device);
......
...@@ -187,7 +187,7 @@ enum port { ...@@ -187,7 +187,7 @@ enum port {
}; };
struct cx25821_board { struct cx25821_board {
char *name; const char *name;
enum port porta; enum port porta;
enum port portb; enum port portb;
enum port portc; enum port portc;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment