Skip to content
  • Ingo Molnar's avatar
    lockdep: warn about lockdep disabling after kernel taint, fix · 27b19565
    Ingo Molnar authored
    Impact: build fix for Sparc and s390
    
    Stephen Rothwell reported that the Sparc build broke:
    
     In file included from kernel/panic.c:12:
     include/linux/debug_locks.h: In function '__debug_locks_off':
     include/linux/debug_locks.h:15: error: implicit declaration of function 'xchg'
    
    due to:
    
     9eeba613
    
    : lockdep: warn about lockdep disabling after kernel taint
    
    There is some inconsistency between architectures about where exactly
    xchg() is defined.
    
    The traditional place is in system.h but the more logical point for it
    is in atomic.h - where most architectures (especially new ones) have
    it defined. These architecture also still offer it via system.h.
    
    Some, such as Sparc or s390 only have it in asm/system.h and not available
    via asm/atomic.h at all.
    
    Use the widest set of headers in debug_locks.h and also include asm/system.h.
    
    Reported-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: "David S. Miller" <davem@davemloft.net>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    LKML-Reference: <20090414144317.026498df.sfr@canb.auug.org.au>
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    27b19565