Skip to content
  • David S. Miller's avatar
    dccp: Fix compile warning in probe code. · d984e619
    David S. Miller authored
    Commit 1386be55
    
     ("dccp: fix
    auto-loading of dccp(_probe)") fixed a bug but created a new
    compiler warning:
    
    net/dccp/probe.c: In function ‘dccpprobe_init’:
    net/dccp/probe.c:166:2: warning: the omitted middle operand in ?: will always be ‘true’, suggest explicit middle operand [-Wparentheses]
    
    try_then_request_module() is built for situations where the
    "existence" test is some lookup function that returns a non-NULL
    object on success, and with a reference count of some kind held.
    
    Here we're looking for a success return of zero from the jprobe
    registry.
    
    Instead of fighting the way try_then_request_module() works, simply
    open code what we want to happen in a local helper function.
    
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    d984e619