Chef Workstation branding dependencies / Remaining work to stable
Chef Workstation contains a lot of various dependencies which include trademarked branding that needs to be looked into. This issue is to track those issues.
Here is the list of dependencies that we need to look into and add some form of a dist.rb:
- chef / chef-bin (ruby)
- chef-zero (ruby)
- inspec / inspec-bin (ruby)
- chef-cli (ruby)
- chef-apply (ruby)
- chef-workstation-app (nodejs)
- main-chef-wrapper (golang)
- chef-analyze (golang)
We need to determine the following for each:
- Whether or not we need to re-brand the particular dependency
- Does it already include support for
dist.rb(or similar) - Add support for
dist.rb(or similar)
| Dependency | Re-brand required | Has dist.rb support |
|---|---|---|
| chef | ||
| chef-zero | ||
| inspec | ||
| chef-cli | ||
| chef-apply |
chef/chef-apply#112 |
|
| chef-workstation-app | ||
| main-chef-wrapper | ||
| chef-analyze | ||
| delivery-cli |
Since these packages are in a variety of languages and formats, there is no universal method to implement distro features, each should be discussed with the project maintainers.
Golang projects are expected to be addressed using the Go code generator by the Chef Workstation team. It was implemented over multiple PRs but this one actually implements it and can be used as reference for further work. Do note that PR does 2 things: Implement the generator (which we'll never need to do again), and apply it in go-libs (the part we'll need to reproduce in other golang projects).
Ruby projects continue to follow the dist.rb approach as with Chef Infra and Inspec
Rust projects have no method in place as of this writing. We'll need to talk with the owners.
Remaining Work
| Problem | Related PR's or Issues | Completed |
|---|---|---|
| Knife bootstrap requires license check |
#3 (closed) cinc-project/upstream/chef@1e0a44dc |
|
| Knife bootstrap uses the incorrect path | cinc-project/upstream/chef@5aace8e8 | |
| Cinc patches for chef-cli |
https://gitlab.com/cinc-project/upstream/chef-cli cinc-project/upstream/chef-workstation@38054d1b |
|
| Use Cinc patched chef-zero | cinc-project/upstream/chef-workstation@38054d1b | |
| Add Chef wrappers | cinc-project/upstream/chef-workstation@a9c68868 | |
| Update help output to use "cinc" naming | cinc-project/upstream/chef-workstation@77ca7fdf | |
| chef-apply (aka cinc-run) |
cinc-project/upstream/chef-workstation@d832f016 https://gitlab.com/cinc-project/upstream/chef-apply chef-apply#134 enforce_license chef-apply#112 dist patches |
|
| 'Unknown product name chef' during chef-run | #6 (closed) | |
| chef-workstation-app needs to be distified | #11 (closed) |