Minor feedback on build instructions
I am following the build instructions right now, and here's some minor feedback:
- It is not clear where to put the Maven settings stuff. I happened to know about $HOME/.m2/settings.xml, so I managed. But I also had to merge your proposed setting with what I already had in there. If there's such a thing as a tool to add a repo to maven, using that would be way easier to understand. Or if there is a way to make it work without editing your global settings.xml, that would be better too.
- All the places DOCKER_HOSTNAME is referenced should probably be a variable reference (i.e. start with $ instead of surrounded by <>) because you asked us to set it to
localhost
above. - The first time I ran
mvn -P system-tests verify
did not work because ofcom.oracle.jdbc
missing, but then I found the instructions inchvote-protocol/README.md
for what to do about that. I think for the open-source release, you should just remove the reference to it; no one will ever be using Oracle when they can be using Postgres for free. I never did getverify
to work, because ofjava.io.IOException: Cannot run program "/Users/jallen/work/chvote2": error=13, Permission denied at ch.ge.ve.ProtocolST.setupSpec(ProtocolST.groovy:167)
(I'll probably make another issue for this, if I manage to debug it further.) - section 2, 3, 4 disagree on the env variable for the location of the source code. Section 1.3 does not mention setting it.
- there is no section 1.4.
More as I find them... :)
Edited by Jeff R. Allen