CNG containers: gitlab-workhorse defaults to older version for master/latest
Summary
The current VERSION of gitlab-workhorse is v7.0.0
. Our default version, when not passed via pipeline trigger variables, is v5.0.0
. As this is also from source, we should set this to master
as well.
Details
When attempting to bring in Maven support in #700 (closed), via !558 (merged), it appeared that we had missing calls to the API. Omnibus builds did not face this problem. Tagged versions of the containers, triggered by tagging versions of upstream GitLab rails codebases, did not have this problem.
While investigating the cause of this difference, I realized two things:
- Our image doesn't output the actual version of gitlab-workhorse, but rather only a
date
output. This is because the Makefile sets this value based ongit describe
- Omnibus reported gitlab-workhorse version
7.0.0-{date}
. This pointed me to the container, and the variables used to configure the Dockerfile. There I found that the CNG's CI file is set tov5.0.0
Edited by Jason Plum