Commit 2583a59b authored by Jason Plum's avatar Jason Plum

Merge branch 'fix-upgrade-logic' into 'master'

Use sort to compare versions in upgrade logic

See merge request charts/gitlab!846

(cherry picked from commit ddecdb49)

d9134308 Use sort to compare versions in upgrade logic
parent 13914101
Pipeline #71986114 passed with stages
in 29 minutes and 55 seconds
title: "Use sort to compare versions in upgrade logic"
merge_request: 846
type: fixed
......@@ -5,6 +5,11 @@ notify() {
echo -n "$1 " >> /dev/termination-log
test "$(printf '%s\n' "$@" | sort -V | tail -n 1)" = "$1";
# Only run check for semver releases
......@@ -36,7 +41,7 @@ OLD_MINOR_VERSION=$(echo $OLD_VERSION_STRING | awk -F "." '{print $1"."$2}')
# (i) if it is a major version jump
# (ii) if existing version is less than required minimum version
if ! $(echo ${OLD_MINOR_VERSION} | awk -v MIN_VERSION="$MIN_VERSION" '$NF+0 < MIN_VERSION {exit 1}'); then
if ! greater_version $OLD_MINOR_VERSION $MIN_VERSION; then
notify "It seems you are upgrading from ${OLD_MAJOR_VERSION}.x version series to ${NEW_MAJOR_VERSION}.x series."
notify "It is recommended to upgrade to the last minor version in a major version series"
notify "first before jumping to the next major version."
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment