Skip to content

Replace subgroup with GitLab class annotation to isolate releases

Hossein Pursultani requested to merge 1233-replace-subgroup-with-annotation into master

Summary of changes

  • GITLAB_CLASS environment variable is introduced to pass the class of GitLab resources that needs to be watched by the controller.
  • GitLab class is added to Watch predicates to filter GitLab resources.

Limitations

This MR does not implement the exact solution that has been specified in #1233. Here're the limitations:

  • GitLab class is passed using GITLAB_CLASS environment variable instead of --gitlab-class. Since adding a CLI introduces a lot of changes to the code-base (see #1294).
  • Operator does not infer class of a GitLab resource when gitlab.com/class annotation is missing. This is partly because I wasn't sure what would be the right value to fall back to (Helm release name is one candidate).

Part of https://gitlab.com/charts/gitlab/issues/1233

Edited by DJ Mountney

Merge request reports