Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
C
charts.gitlab.io
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Jobs
  • Commits
  • charts
  • charts.gitlab.io
  • Merge Requests
  • !99

Closed
Opened Jan 13, 2018 by Tobias L. Maier@tmaier🍍
  • Report abuse
Report abuse

gitlab-runner: Add preStop hook to unregister all runners

Use a preStop hook to unregister the runner before terminating the Pod.

https://kubernetes.io/docs/tasks/configure-pod-container/attach-handler-lifecycle-event/

Possibly a sufficient fix for #113. We still get a new pod name, but at least the old ones are getting deleted now

Edited Jan 13, 2018 by Tobias L. Maier

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/tmaier/charts.gitlab.io.git pre-stop
git checkout -b tmaier/charts.gitlab.io-pre-stop FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff tmaier/charts.gitlab.io-pre-stop

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 2
  • Commits 1
  • Pipelines 1
  • Changes 1
Assignee
No assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: charts/charts.gitlab.io!99