• Eugen Rochko's avatar
    Fix UserTrackingConcern firing on every request, optimize some queries (#5368) · b8db386e
    Eugen Rochko authored
    - For some reason, :if option on before_action did not work. It got
      executed every time, returned false, and the action run anyway,
      which led to the current_sign_in_at and sign_in_count being
      updated on every request
    - Return "do not filter" early in FeedManager#filter_from_home? if
      the status is authored by receiver. Usually this method is not
      called for own statuses at all, but it is called when Feed#get
      uses the database
    - Return early if #reload_stale_associations! has nothing to load
      to save a database query with WHERE 1=0
notification.rb 2.99 KB