Commits · abartlet-winbind-trust-fail · Catalyst Samba Development / samba

28 May, 2018 1 commit

torture: Cope with WINBINDD_SHOW_SEQUENCE failure for fake trusts · af3d43e0

Andrew Bartlett authored May 28, 2018



This test has been flapping and we should not be checking the
sequence number of remote trusts in a loop like this.  We can write
a test against the trusts we specifically set up if we want to check
remote sequence numbers (and connectivity) against actually working
domains.

When flapping the previous version of the test gave:

 WARNING!: ../source4/torture/winbind/struct_based.c:812: WINBINDD_SHOW_SEQUENCE returned 0, expected 1: WINBINDD_SHOW_SEQUENCE
 WARNING!: WINBINDD_SHOW_SEQUENCE on domain torturedom failed

 Trust list for WINBINDD_SHOW_SEQUENCE was:
 BUILTIN
 S4MEMBER
 SAMBADOMAIN
 torturedom

 WARNING!: ../source4/torture/winbind/struct_based.c:812: WINBINDD_SHOW_SEQUENCE returned 0, expected 1: WINBINDD_SHOW_SEQUENCE
 WARNING!: WINBINDD_SHOW_SEQUENCE on domain TORTURE302 failed

 Trust list for WINBINDD_SHOW_SEQUENCE was:
 BUILTIN
 S4MEMBER
 SAMBADOMAIN
 TORTURE302
 TORTURE306

Signed-off-by: Andrew Bartlett <abartlet@samba.org>

af3d43e0

25 May, 2018 36 commits

vfs_gpfs: Use full_path_tos instead of talloc_asprintf · 1531fcde

Christof Schmitt authored May 22, 2018 and

Jeremy Allison committed May 26, 2018



full_path_tos avoids the talloc call for most cases; use that instead of
talloc_asprintf.

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat May 26 01:43:09 CEST 2018 on sn-devel-144

1531fcde

vfs_gpfs: Remove get_full_smb_filename from is_offline check · 1843a2d6
Christof Schmitt authored May 22, 2018 and Jeremy Allison committed May 25, 2018
```
No stream information is required here.

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
```
1843a2d6

vfs_gpfs: Remove wrong get_full_smb_filename from ntimes function · 4a29a949

Christof Schmitt authored May 22, 2018 and

Jeremy Allison committed May 25, 2018



Updating the timestamps requires the path to the file, but no stream
information.

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

4a29a949

vfs_gpfs: Adjust debug level when get_winattrs returns EBADF · 01a6aef5

Christof Schmitt authored May 23, 2018 and

Jeremy Allison committed May 25, 2018



This is returned for a get_winattrs call against a non-gpfs file system.
This can happen for the .. entry when listing a share on the file system
root.

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

01a6aef5

smbd: Move dfree_info struct · 9a79a61a

Christof Schmitt authored May 16, 2018 and

Jeremy Allison committed May 25, 2018



As the struct is no longer used as part of connection_struct, move it to
dfree.c.

This is not backported, as it would change the VFS ABI.

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

9a79a61a

smbd: Flush dfree memcache on service reload · e30d0c0e

Christof Schmitt authored May 18, 2018 and

Jeremy Allison committed May 25, 2018

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13446



Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

e30d0c0e

smbd: Cache dfree information based on query path · 8f121747

Christof Schmitt authored May 16, 2018 and

Jeremy Allison committed May 25, 2018

Sub directories in a SMB share can have different free space information
(e.g. when a different file system is mounted there). Caching the dfree
information per SMB share will return invalid data. Address this by
switching to memcache and store the cached data based on the query path.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13446



Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

8f121747

memcache: Add new cache type for dfree information · f5d05562

Christof Schmitt authored May 16, 2018 and

Jeremy Allison committed May 25, 2018

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13446



Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

f5d05562

selftest: Add test for 'dfree cache' · a55b3d2f

Christof Schmitt authored May 23, 2018 and

Jeremy Allison committed May 25, 2018

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13446



Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

a55b3d2f

selftest: Add dfq_cache share with 'dfree cache time' set · 7ffcbd5c

Christof Schmitt authored May 23, 2018 and

Jeremy Allison committed May 25, 2018

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13446



Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

7ffcbd5c

s3: vfs_fake_acls: Correctly implement the chmod/fchmod algorithm on fake acls. · 52778afd

Jeremy Allison authored May 18, 2018



We now pass samba3hide(nt4_dc), so remove it from knownfail.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri May 25 21:29:32 CEST 2018 on sn-devel-144

52778afd

s3: smbd: Make map_acl_perms_to_permset() extern. · e85a662e

Jeremy Allison authored May 18, 2018



The vfs_fake_acl module will need it to implement chown/fchown.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

e85a662e

s3: smbd: Make unix_perms_to_acl_perms() extern. · 109d94d1

Jeremy Allison authored May 18, 2018



The vfs_fake_acl module will need it to implement chown/fchown.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

109d94d1

s3: posix_acls: Remove unused 'connection_struct *conn' parameter to map_acl_perms_to_permset(). · a41155b0
Jeremy Allison authored May 18, 2018
```
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
```
a41155b0
s3: posix_acls: Remove dead functions fchmod_acl()/chmod_acl(). · cfbe3048
Jeremy Allison authored May 17, 2018
```
No longer used.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
```
cfbe3048

s3: VFS: Remove SMB_VFS_FCHMOD_ACL(). · 5bbb8310

Jeremy Allison authored May 17, 2018



No longer used.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

5bbb8310

s3: torture: Remove cmd_fchmod_acl(). · a3d7544b

Jeremy Allison authored May 17, 2018



No longer needed.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

a3d7544b

s3: modules: vfs_ceph: Remove FCHMOD_ACL in cephwrap_fchmod(). · 55f013ed

Jeremy Allison authored May 17, 2018



Now I understand the use of the mask in POSIX ACLs
this extra step is no longer needed.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

55f013ed

s3: modules: vfs_default: Remove FCHMOD_ACL in fchmod. · 0c65f6b8

Jeremy Allison authored May 17, 2018



Now I understand the use of the mask in POSIX ACLs
this extra step is no longer needed.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

0c65f6b8

s3: VFS: Remove SMB_VFS_CHMOD_ACL(). · 7b8fa17f

Jeremy Allison authored May 17, 2018



No longer used.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

7b8fa17f

s3: torture: Remove cmd_chmod_acl(). · 7d3059cd

Jeremy Allison authored May 17, 2018



No longer needed.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

7d3059cd

s3: modules: vfs_ceph: Remove CHMOD_ACL in cephwrap_chmod(). · b8477abb

Jeremy Allison authored May 17, 2018



Now I understand the use of the mask in POSIX ACLs
this extra step is no longer needed.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

b8477abb

s3: modules: vfs_ceph: Remove CHMOD_ACL in cephwrap_mkdir(). · d50bb460

Jeremy Allison authored May 17, 2018



Now I understand the use of the mask in POSIX ACLs
this extra step is no longer needed.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

d50bb460

s3: modules: vfs_default: Remove CHMOD_ACL in chmod. · c5060e1a

Jeremy Allison authored May 17, 2018



Now I understand the use of the mask in POSIX ACLs
this extra step is no longer needed.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

c5060e1a

s3: modules: vfs_default: Remove CHMOD_ACL in mkdir. · 90117f25

Jeremy Allison authored May 17, 2018



Now I understand the use of the mask in POSIX ACLs
this extra step is no longer needed. If the mkdir
succeeded it's already set the correct mode.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

90117f25

s3: smbd: Use FCHMOD call, not FCHMOD_ACL call if mode bits reset needed. · aaed6b4e

Jeremy Allison authored May 17, 2018



This is a behavior change, it will modify the POSIX ACL mask
from a value of rwx instead of modifying the existing ACE
entries to be ANDed with the passed in mode. However it
will have no effect on the underlying permissions, and
better reflects the proper use of POSIX ACLs (i.e. I
didn't understand the use of the mask entry in the
ACL when I first wrote the POSIX ACL code).

In addition, the vfs_acl_common.c module already
filters these calls for all but POSIX opens, which
means the only place this change is exposed to the
client would be a cifsfs unix extensions client doing
posix acl calls (and they would expect the mask to
be set like this on chmod).

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

aaed6b4e

s3: smbd: Optimization. Only do the FCHMOD_ACL call if mode bits not equal. · 2f4e581c
Jeremy Allison authored May 17, 2018
```
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
```
2f4e581c
s3: smbd: optimization. Only do the FCHMOD call if needed. · 4f6c71ae
Jeremy Allison authored May 17, 2018
```
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
```
4f6c71ae

s3: smbd: Remove use of SMB_VFS_FCHMOD_ACL() in overwrite case. · d03e9a86

Jeremy Allison authored May 17, 2018



We have potentially called SMB_VFS_FCHMOD() here in
the file_set_dosmode() call associated with the comment
/* Overwritten files should be initially set as archive */
at line 3755 above, so there is no need to do any POSIX ACL
mask protection.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

d03e9a86

s3: smbd: Add clarifying comment on mode change on overwritten files. · 41ee89b2
Jeremy Allison authored May 17, 2018
```
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
```
41ee89b2
s3: smbd: Remove existing_unx_mode, an unused parameter to open_match_attributes(). · a6c03f2a
Jeremy Allison authored May 17, 2018
```
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
```
a6c03f2a

smbd: Call smbXsrv_client_global_init in the parent smbd · 33d1ac85

VL authored May 24, 2018



Otherwise we're missing the clear-if-first optimization for
smbXsrv_client_global.tdb.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Fri May 25 16:00:08 CEST 2018 on sn-devel-144

33d1ac85

vfs_time_audit: Fix a log message · ae196c50

VL authored May 22, 2018



Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

ae196c50

autobuild: cover the Gentoo case with python disabled all down the stack · e9b638c4

Andrew Bartlett authored May 10, 2018 and

Stefan Metzmacher committed May 25, 2018



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Fri May 25 13:07:47 CEST 2018 on sn-devel-144

e9b638c4

Make ldb configuration --disable-python work as intended · 95c117ff

Timur I. Bakeyev authored May 18, 2018 and

Stefan Metzmacher committed May 25, 2018



Signed-off-by: Timur I. Bakeyev <timur@iXsystems.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

95c117ff

torture: Give extra information on WINBINDD_SHOW_SEQUENCE failure · 4c354cd5
Andrew Bartlett authored May 24, 2018 and Stefan Metzmacher committed May 25, 2018
```
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
```
4c354cd5

24 May, 2018 2 commits

s3:utils: Remove double error check · a9084dce

Andreas Schneider authored May 23, 2018 and

Günther Deschner committed May 24, 2018



Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>

Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Thu May 24 18:07:03 CEST 2018 on sn-devel-144

a9084dce

ldap_server: Fix CID 1435721 Unchecked return value · 29163012

VL authored May 22, 2018 and

Jeremy Allison committed May 24, 2018



Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu May 24 03:35:00 CEST 2018 on sn-devel-144

29163012

23 May, 2018 1 commit
- kdc: Fix CID 1435720 Unchecked return value · 3aae048a
  VL authored May 22, 2018 and Jeremy Allison committed May 24, 2018
```
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
```
  3aae048a