- 28 May, 2018 11 commits
-
-
Andrew Bartlett authored
* New LMDB backend * Comprehensive tests for index behaviour * Enforce transactions for writes * Enforce read lock use for all reads * Fix memory leak in paged_results module. We hold at most 10 outstanding paged result cookies (bug #13362) * Fix compiler warnings * Python3 improvements * Restore --disable-python build * Fix for performance regression on one-level searches (bug #13448) * Samba's subtree_rename could fail to rename some entires (bug #13452) Signed-off-by:
Andrew Bartlett <abartlet@samba.org> Reviewed-by:
Stefan Metzmacher <metze@samba.org>
-
Andrew Bartlett authored
We should add some other more complex operations here. Signed-off-by:
Andrew Bartlett <abartlet@samba.org> BUG: https://bugzilla.samba.org/show_bug.cgi?id=13448
-
Andrew Bartlett authored
Signed-off-by:
Andrew Bartlett <abartlet@samba.org> BUG: https://bugzilla.samba.org/show_bug.cgi?id=13448
-
When no search filter is specified, the code falls back to using '(|(objectClass=*)(distinguishedName=*)'. ltdb_index_dn() then failed because matching against '*' is not indexed. The error return then caused the code to fallback to a full-scan of the DB, which could have a considerable performance hit. Instead, we want to continue on and do the ltdb_index_filter() over the indexed results that were returned. Signed-off-by:
Andrew Bartlett <abartlet@samba.org> Signed-off-by:
Tim Beale <timbeale@catalyst.net.nz> BUG: https://bugzilla.samba.org/show_bug.cgi?id=13448
-
Andrew Bartlett authored
Signed-off-by:
Andrew Bartlett <abartlet@samba.org>
-
Andrew Bartlett authored
Signed-off-by:
Andrew Bartlett <abartlet@samba.org>
-
Andrew Bartlett authored
Otherwise Samba modules like subtree_rename can fail as they modify the index during the callback. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13452 Signed-off-by:
Andrew Bartlett <abartlet@samba.org>
-
Andrew Bartlett authored
Signed-off-by:
Andrew Bartlett <abartlet@samba.org>
-
Andrew Bartlett authored
The sort was written back when the module did not operate recursivly over the tree. Now it is just confusing, so replace with useful comments. Signed-off-by:
Andrew Bartlett <abartlet@samba.org>
-
Andrew Bartlett authored
Signed-off-by:
Andrew Bartlett <abartlet@samba.org>
-
Andrew Bartlett authored
This will allow running multiple tests against the same tree. This tree is very similar to the tree produced by the KCC test that simply does a tree_delete, and I want to lock down the tree_delete behaviour. Signed-off-by:
Andrew Bartlett <abartlet@samba.org>
-
- 25 May, 2018 29 commits
-
-
full_path_tos avoids the talloc call for most cases; use that instead of talloc_asprintf. Signed-off-by:
Christof Schmitt <cs@samba.org> Reviewed-by:
Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Sat May 26 01:43:09 CEST 2018 on sn-devel-144
-
No stream information is required here. Signed-off-by:
Christof Schmitt <cs@samba.org> Reviewed-by:
Jeremy Allison <jra@samba.org>
-
Updating the timestamps requires the path to the file, but no stream information. Signed-off-by:
Christof Schmitt <cs@samba.org> Reviewed-by:
Jeremy Allison <jra@samba.org>
-
This is returned for a get_winattrs call against a non-gpfs file system. This can happen for the .. entry when listing a share on the file system root. Signed-off-by:
Christof Schmitt <cs@samba.org> Reviewed-by:
Jeremy Allison <jra@samba.org>
-
As the struct is no longer used as part of connection_struct, move it to dfree.c. This is not backported, as it would change the VFS ABI. Signed-off-by:
Christof Schmitt <cs@samba.org> Reviewed-by:
Jeremy Allison <jra@samba.org>
-
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13446 Signed-off-by:
Christof Schmitt <cs@samba.org> Reviewed-by:
Jeremy Allison <jra@samba.org>
-
Sub directories in a SMB share can have different free space information (e.g. when a different file system is mounted there). Caching the dfree information per SMB share will return invalid data. Address this by switching to memcache and store the cached data based on the query path. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13446 Signed-off-by:
Christof Schmitt <cs@samba.org> Reviewed-by:
Jeremy Allison <jra@samba.org>
-
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13446 Signed-off-by:
Christof Schmitt <cs@samba.org> Reviewed-by:
Jeremy Allison <jra@samba.org>
-
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13446 Signed-off-by:
Christof Schmitt <cs@samba.org> Reviewed-by:
Jeremy Allison <jra@samba.org>
-
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13446 Signed-off-by:
Christof Schmitt <cs@samba.org> Reviewed-by:
Jeremy Allison <jra@samba.org>
-
Jeremy Allison authored
We now pass samba3hide(nt4_dc), so remove it from knownfail. Signed-off-by:
Jeremy Allison <jra@samba.org> Reviewed-by:
Volker Lendecke <vl@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Fri May 25 21:29:32 CEST 2018 on sn-devel-144
-
Jeremy Allison authored
The vfs_fake_acl module will need it to implement chown/fchown. Signed-off-by:
Jeremy Allison <jra@samba.org> Reviewed-by:
Volker Lendecke <vl@samba.org>
-
Jeremy Allison authored
The vfs_fake_acl module will need it to implement chown/fchown. Signed-off-by:
Jeremy Allison <jra@samba.org> Reviewed-by:
Volker Lendecke <vl@samba.org>
-
Jeremy Allison authored
Signed-off-by:
Jeremy Allison <jra@samba.org> Reviewed-by:
Volker Lendecke <vl@samba.org>
-
Jeremy Allison authored
No longer used. Signed-off-by:
Jeremy Allison <jra@samba.org> Reviewed-by:
Volker Lendecke <vl@samba.org>
-
Jeremy Allison authored
No longer used. Signed-off-by:
Jeremy Allison <jra@samba.org> Reviewed-by:
Volker Lendecke <vl@samba.org>
-
Jeremy Allison authored
No longer needed. Signed-off-by:
Jeremy Allison <jra@samba.org> Reviewed-by:
Volker Lendecke <vl@samba.org>
-
Jeremy Allison authored
Now I understand the use of the mask in POSIX ACLs this extra step is no longer needed. Signed-off-by:
Jeremy Allison <jra@samba.org> Reviewed-by:
Volker Lendecke <vl@samba.org>
-
Jeremy Allison authored
Now I understand the use of the mask in POSIX ACLs this extra step is no longer needed. Signed-off-by:
Jeremy Allison <jra@samba.org> Reviewed-by:
Volker Lendecke <vl@samba.org>
-
Jeremy Allison authored
No longer used. Signed-off-by:
Jeremy Allison <jra@samba.org> Reviewed-by:
Volker Lendecke <vl@samba.org>
-
Jeremy Allison authored
No longer needed. Signed-off-by:
Jeremy Allison <jra@samba.org> Reviewed-by:
Volker Lendecke <vl@samba.org>
-
Jeremy Allison authored
Now I understand the use of the mask in POSIX ACLs this extra step is no longer needed. Signed-off-by:
Jeremy Allison <jra@samba.org> Reviewed-by:
Volker Lendecke <vl@samba.org>
-
Jeremy Allison authored
Now I understand the use of the mask in POSIX ACLs this extra step is no longer needed. Signed-off-by:
Jeremy Allison <jra@samba.org> Reviewed-by:
Volker Lendecke <vl@samba.org>
-
Jeremy Allison authored
Now I understand the use of the mask in POSIX ACLs this extra step is no longer needed. Signed-off-by:
Jeremy Allison <jra@samba.org> Reviewed-by:
Volker Lendecke <vl@samba.org>
-
Jeremy Allison authored
Now I understand the use of the mask in POSIX ACLs this extra step is no longer needed. If the mkdir succeeded it's already set the correct mode. Signed-off-by:
Jeremy Allison <jra@samba.org> Reviewed-by:
Volker Lendecke <vl@samba.org>
-
Jeremy Allison authored
This is a behavior change, it will modify the POSIX ACL mask from a value of rwx instead of modifying the existing ACE entries to be ANDed with the passed in mode. However it will have no effect on the underlying permissions, and better reflects the proper use of POSIX ACLs (i.e. I didn't understand the use of the mask entry in the ACL when I first wrote the POSIX ACL code). In addition, the vfs_acl_common.c module already filters these calls for all but POSIX opens, which means the only place this change is exposed to the client would be a cifsfs unix extensions client doing posix acl calls (and they would expect the mask to be set like this on chmod). Signed-off-by:
Jeremy Allison <jra@samba.org> Reviewed-by:
Volker Lendecke <vl@samba.org>
-
Jeremy Allison authored
Signed-off-by:
Jeremy Allison <jra@samba.org> Reviewed-by:
Volker Lendecke <vl@samba.org>
-
Jeremy Allison authored
Signed-off-by:
Jeremy Allison <jra@samba.org> Reviewed-by:
Volker Lendecke <vl@samba.org>
-
Jeremy Allison authored
We have potentially called SMB_VFS_FCHMOD() here in the file_set_dosmode() call associated with the comment /* Overwritten files should be initially set as archive */ at line 3755 above, so there is no need to do any POSIX ACL mask protection. Signed-off-by:
Jeremy Allison <jra@samba.org> Reviewed-by:
Volker Lendecke <vl@samba.org>
-