Allow pipelines to set attributes based on results

This exposes the results to cachable markdown models. If the developer
sets a key in the hash and the model has a matching attribute that
attribute will be set to the pipeline results value. Whilst this is
super useful it is also quite dangerous as if someone sets a value on
the results hash that inadvertently clobbers an unintended attribute.
47 jobs for democratic_emojis in 66 minutes and 26 seconds (queued for 5 seconds)
latest
Status Job ID Name Coverage
  Prepare
passed #9445741
gitlab-org 2gb
knapsack

00:02:25

passed #9445742
gitlab-org 2gb
setup-test-env

00:11:52

 
  Test
passed #9445784
gitlab-org 2gb
bundler:check

00:09:55

passed #9445778
gitlab-org 2gb
license_finder

00:09:23

passed #9445783
gitlab-org 2gb
lint-doc

00:00:39

passed #9445785
gitlab-org 2gb
lint:javascript

00:00:59

passed #9445776
gitlab-org 2gb
rake brakeman

00:07:07

passed #9445780
gitlab-org 2gb
rake db:migrate:reset

00:10:37

passed #9445781
gitlab-org 2gb
rake db:seed_fu

00:06:49

passed #9445779
gitlab-org 2gb
rake downtime_check

00:06:42

passed #9445777
gitlab-org 2gb
rake flay

00:06:05

passed #9445774
gitlab-org 2gb
rake haml_lint

00:06:41

passed #9445775
gitlab-org 2gb
rake scss_lint

00:10:30

failed #9445743
gitlab-org 2gb
rspec 0 20

00:40:26

failed #9445744
gitlab-org 2gb
rspec 1 20

00:17:49

failed #9445753
gitlab-org 2gb
rspec 10 20

00:54:19

passed #9445754
gitlab-org 2gb
rspec 11 20

00:30:33

failed #9445755
gitlab-org 2gb
rspec 12 20

00:26:46

failed #9445756
gitlab-org 2gb
rspec 13 20

00:35:17

failed #9445757
gitlab-org 2gb
rspec 14 20

00:53:57

passed #9445758
gitlab-org 2gb
rspec 15 20

00:31:55

passed #9445759
gitlab-org 2gb
rspec 16 20

00:38:02

failed #9445760
gitlab-org 2gb
rspec 17 20

00:19:16

failed #9445761
gitlab-org 2gb
rspec 18 20

00:24:16

failed #9445762
gitlab-org 2gb
rspec 19 20

00:33:16

failed #9445745
gitlab-org 2gb
rspec 2 20

00:25:22

failed #9445746
gitlab-org 2gb
rspec 3 20

00:51:37

passed #9445747
gitlab-org 2gb
rspec 4 20

00:20:39

passed #9445748
gitlab-org 2gb
rspec 5 20

00:19:11

passed #9445749
gitlab-org 2gb
rspec 6 20

00:17:05

passed #9445750
gitlab-org 2gb
rspec 7 20

00:47:12

passed #9445751
gitlab-org 2gb
rspec 8 20

00:19:55

passed #9445752
gitlab-org 2gb
rspec 9 20

00:48:46

passed #9445773
gitlab-org 2gb
rubocop

00:08:42

passed #9445763
gitlab-org 2gb
spinach 0 10

00:14:17

passed #9445764
gitlab-org 2gb
spinach 1 10

00:14:11

failed #9445765
gitlab-org 2gb
spinach 2 10

00:14:09

passed #9445766
gitlab-org 2gb
spinach 3 10

00:15:15

failed #9445767
gitlab-org 2gb
spinach 4 10

00:24:17

passed #9445768
gitlab-org 2gb
spinach 5 10

00:25:34

passed #9445769
gitlab-org 2gb
spinach 6 10

00:13:17

passed #9445770
gitlab-org 2gb
spinach 7 10

00:30:16

passed #9445771
gitlab-org 2gb
spinach 8 10

00:45:14

passed #9445772
gitlab-org 2gb
spinach 9 10

00:17:23

failed #9445782
gitlab-org 2gb
teaspoon

00:17:32

 
  Post Test
skipped #9445786
gitlab-org 2gb
coverage
skipped #9445787
gitlab-org 2gb
lint:javascript:report
 
Name Stage Failure
failed
rspec 2 20 Test There is an unknown failure, please try again
689 examples, 3 failures

Failed examples:

rspec ./spec/services/merge_requests/update_service_spec.rb:257 # MergeRequests::UpdateService execute when MergeRequest has tasks
rspec ./spec/services/merge_requests/update_service_spec.rb:262 # MergeRequests::UpdateService execute when MergeRequest has tasks when tasks are marked as completed creates system note about task status change
rspec ./spec/services/merge_requests/update_service_spec.rb:277 # MergeRequests::UpdateService execute when MergeRequest has tasks when tasks are marked as incomplete creates system note about task status change

ERROR: Build failed: exit code 1
failed
rspec 12 20 Test There is an unknown failure, please try again
rspec './spec/services/system_note_service_spec.rb[1:17:2:1:2]' # SystemNoteService.noteable_moved moved from behaves like cross project mentionable mentions referenced noteable
rspec './spec/services/system_note_service_spec.rb[1:17:2:1:3]' # SystemNoteService.noteable_moved moved from behaves like cross project mentionable mentions referenced project
rspec ./spec/services/system_note_service_spec.rb:560 # SystemNoteService.noteable_moved invalid direction raises error
rspec ./spec/services/system_note_service_spec.rb:645 # SystemNoteService JIRA integration new reference for issues creates comment
rspec ./spec/services/system_note_service_spec.rb:651 # SystemNoteService JIRA integration new reference for issues creates remote link
rspec ./spec/services/system_note_service_spec.rb:731 # SystemNoteService.discussion_continued_in_issue creates a new note in the discussion
rspec ./spec/services/system_note_service_spec.rb:737 # SystemNoteService.discussion_continued_in_issue mentions the created issue in the system note

ERROR: Build failed: exit code 1
failed
rspec 13 20 Test There is an unknown failure, please try again
Failed examples:

rspec ./spec/requests/api/issues_spec.rb:774 # API::Issues POST /projects/:id/issues resolving issues in a merge request creates a new project issue
rspec ./spec/requests/api/issues_spec.rb:778 # API::Issues POST /projects/:id/issues resolving issues in a merge request resolves the discussions in a merge request
rspec ./spec/requests/api/issues_spec.rb:784 # API::Issues POST /projects/:id/issues resolving issues in a merge request assigns a description to the issue mentioning the merge request
rspec ./spec/requests/api/issues_spec.rb:1077 # API::Issues /projects/:id/issues/:issue_id/move moves an issue
rspec ./spec/requests/api/issues_spec.rb:1105 # API::Issues /projects/:id/issues/:issue_id/move moves the issue to another namespace if I am admin

ERROR: Build failed: exit code 1
failed
rspec 14 20 Test There is an unknown failure, please try again
rspec ./spec/services/todo_service_spec.rb:428 # TodoService Merge Requests #reassigned_merge_request creates a todo if new assignee is the current user
rspec ./spec/services/todo_service_spec.rb:435 # TodoService Merge Requests #reassigned_merge_request does not create a todo for guests
rspec ./spec/services/todo_service_spec.rb:442 # TodoService Merge Requests #merge_merge_request marks related pending todos to the target for the user as done
rspec ./spec/services/todo_service_spec.rb:451 # TodoService Merge Requests #merge_merge_request does not create todo for guests
rspec ./spec/services/todo_service_spec.rb:458 # TodoService Merge Requests #new_award_emoji marks related pending todos to the target for the user as done
rspec ./spec/services/todo_service_spec.rb:475 # TodoService Merge Requests #merge_request_push marks related pending todos to the target for the user as done
rspec ./spec/services/todo_service_spec.rb:510 # TodoService Merge Requests #new_note does not create todo for guests

ERROR: Build failed: exit code 1
failed
rspec 19 20 Test There is an unknown failure, please try again
rspec ./spec/features/security/project/snippet/public_access_spec.rb:64 # Public Project Snippets Access GET /:project_path/snippets/:id for an internal snippet should be allowed for user
rspec ./spec/features/security/project/snippet/public_access_spec.rb:72 # Public Project Snippets Access GET /:project_path/snippets/:id for a private snippet should be allowed for admin
rspec ./spec/features/security/project/snippet/public_access_spec.rb:73 # Public Project Snippets Access GET /:project_path/snippets/:id for a private snippet should be allowed for owner
rspec ./spec/features/security/project/snippet/public_access_spec.rb:74 # Public Project Snippets Access GET /:project_path/snippets/:id for a private snippet should be allowed for master
rspec ./spec/features/security/project/snippet/public_access_spec.rb:75 # Public Project Snippets Access GET /:project_path/snippets/:id for a private snippet should be allowed for developer
rspec ./spec/features/security/project/snippet/public_access_spec.rb:76 # Public Project Snippets Access GET /:project_path/snippets/:id for a private snippet should be allowed for reporter
rspec ./spec/features/security/project/snippet/public_access_spec.rb:77 # Public Project Snippets Access GET /:project_path/snippets/:id for a private snippet should be allowed for guest

ERROR: Build failed: exit code 1
failed
rspec 1 20 Test There is an unknown failure, please try again
Finished in 10 minutes 18 seconds (files took 13.56 seconds to load)
809 examples, 2 failures

Failed examples:

rspec ./spec/features/snippets/create_snippet_spec.rb:9 # Create Snippet Authenticated user creates a snippet
rspec ./spec/features/snippets/create_snippet_spec.rb:21 # Create Snippet Authenticated user creates a snippet with + in filename

ERROR: Build failed: exit code 1
failed
spinach 4 10 Test There is an unknown failure, please try again
  /builds/callumdryden/gitlab-ce/vendor/ruby/2.3.0/gems/spinach-0.8.10/lib/spinach/runner.rb:74:in `each'
/builds/callumdryden/gitlab-ce/vendor/ruby/2.3.0/gems/spinach-0.8.10/lib/spinach/runner.rb:74:in `run'
/builds/callumdryden/gitlab-ce/vendor/ruby/2.3.0/gems/spinach-0.8.10/lib/spinach/cli.rb:27:in `run'
/builds/callumdryden/gitlab-ce/vendor/ruby/2.3.0/gems/spinach-0.8.10/bin/spinach:15:in `<top (required)>'
/builds/callumdryden/gitlab-ce/vendor/ruby/2.3.0/bin/spinach:22:in `load'
/builds/callumdryden/gitlab-ce/vendor/ruby/2.3.0/bin/spinach:22:in `<top (required)>'
Retrying 2...
Retrying 1...
ERROR: Build failed: exit code 1
failed
spinach 2 10 Test There is an unknown failure, please try again
Knapsack report was generated. Preview:
{
"features/snippets/snippets.feature": 14.370458841323853
}

Steps Summary: (19) Successful, (0) Pending, (0) Undefined, (0) Failed, (5) Error

Finished in 14.389614928 seconds
ERROR: Build failed: exit code 1
failed
rspec 0 20 Test There is an unknown failure, please try again
1090 examples, 3 failures, 11 pending

Failed examples:

rspec ./spec/services/issues/create_service_spec.rb:152 # Issues::CreateService#execute for a merge request resolves the discussion for the merge request
rspec ./spec/services/issues/create_service_spec.rb:159 # Issues::CreateService#execute for a merge request added a system note to the discussion
rspec ./spec/services/issues/create_service_spec.rb:167 # Issues::CreateService#execute for a merge request assigns the title and description for the issue

ERROR: Build failed: exit code 1
failed
rspec 3 20 Test There is an unknown failure, please try again
rspec ./spec/lib/gitlab/import_export/attribute_configuration_spec.rb:26 # Import/Export attribute configuration has no new columns
rspec ./spec/services/issues/update_service_spec.rb:279 # Issues::UpdateService execute when issue has tasks
rspec ./spec/services/issues/update_service_spec.rb:284 # Issues::UpdateService execute when issue has tasks when tasks are marked as completed creates system note about task status change
rspec ./spec/services/issues/update_service_spec.rb:299 # Issues::UpdateService execute when issue has tasks when tasks are marked as incomplete creates system note about task status change
rspec ./spec/services/issues/update_service_spec.rb:314 # Issues::UpdateService execute when issue has tasks when tasks position has been modified does not create a system note
rspec ./spec/services/issues/update_service_spec.rb:327 # Issues::UpdateService execute when issue has tasks when a Task list with a completed item is totally replaced does not create a system note referencing the position the old item
rspec ./spec/services/issues/update_service_spec.rb:333 # Issues::UpdateService execute when issue has tasks when a Task list with a completed item is totally replaced does not generate a new note at all

ERROR: Build failed: exit code 1
failed
rspec 17 20 Test There is an unknown failure, please try again
rspec ./spec/features/security/project/snippet/internal_access_spec.rb:49 # Internal Project Snippets Access GET /:project_path/snippets/:id for an internal snippet should be allowed for user
rspec ./spec/features/security/project/snippet/internal_access_spec.rb:57 # Internal Project Snippets Access GET /:project_path/snippets/:id for a private snippet should be allowed for admin
rspec ./spec/features/security/project/snippet/internal_access_spec.rb:58 # Internal Project Snippets Access GET /:project_path/snippets/:id for a private snippet should be allowed for owner
rspec ./spec/features/security/project/snippet/internal_access_spec.rb:59 # Internal Project Snippets Access GET /:project_path/snippets/:id for a private snippet should be allowed for master
rspec ./spec/features/security/project/snippet/internal_access_spec.rb:60 # Internal Project Snippets Access GET /:project_path/snippets/:id for a private snippet should be allowed for developer
rspec ./spec/features/security/project/snippet/internal_access_spec.rb:61 # Internal Project Snippets Access GET /:project_path/snippets/:id for a private snippet should be allowed for reporter
rspec ./spec/features/security/project/snippet/internal_access_spec.rb:62 # Internal Project Snippets Access GET /:project_path/snippets/:id for a private snippet should be allowed for guest

ERROR: Build failed: exit code 1
failed
rspec 10 20 Test There is an unknown failure, please try again
rspec ./spec/features/task_lists_spec.rb:211 # Task Lists for Merge Requests multiple tasks contains the required selectors
rspec ./spec/features/task_lists_spec.rb:223 # Task Lists for Merge Requests multiple tasks is only editable by author
rspec ./spec/features/task_lists_spec.rb:234 # Task Lists for Merge Requests multiple tasks provides a summary on MergeRequests#index
rspec ./spec/features/task_lists_spec.rb:243 # Task Lists for Merge Requests single incomplete task renders for description
rspec ./spec/features/task_lists_spec.rb:251 # Task Lists for Merge Requests single incomplete task provides a summary on MergeRequests#index
rspec ./spec/features/task_lists_spec.rb:260 # Task Lists for Merge Requests single complete task renders for description
rspec ./spec/features/task_lists_spec.rb:268 # Task Lists for Merge Requests single complete task provides a summary on MergeRequests#index

ERROR: Build failed: exit code 1
failed
rspec 18 20 Test There is an unknown failure, please try again

rspec ./spec/features/security/project/snippet/private_access_spec.rb:41 # Private Project Snippets Access GET /:project_path/snippets/:id for a private snippet should be allowed for admin
rspec ./spec/features/security/project/snippet/private_access_spec.rb:42 # Private Project Snippets Access GET /:project_path/snippets/:id for a private snippet should be allowed for owner
rspec ./spec/features/security/project/snippet/private_access_spec.rb:43 # Private Project Snippets Access GET /:project_path/snippets/:id for a private snippet should be allowed for master
rspec ./spec/features/security/project/snippet/private_access_spec.rb:44 # Private Project Snippets Access GET /:project_path/snippets/:id for a private snippet should be allowed for developer
rspec ./spec/features/security/project/snippet/private_access_spec.rb:45 # Private Project Snippets Access GET /:project_path/snippets/:id for a private snippet should be allowed for reporter
rspec ./spec/features/security/project/snippet/private_access_spec.rb:46 # Private Project Snippets Access GET /:project_path/snippets/:id for a private snippet should be allowed for guest

ERROR: Build failed: exit code 1
failed
teaspoon Test There is an unknown failure, please try again
Finished in 6 minutes 53 seconds (files took 27.27 seconds to load)
30 examples, 1 failure

Failed examples:

rspec ./spec/javascripts/fixtures/issues.rb:28 # Projects::IssuesController (JavaScript fixtures) issues/issue-with-task-list.html.raw

/usr/local/bin/ruby -I/builds/callumdryden/gitlab-ce/vendor/ruby/2.3.0/gems/rspec-core-3.5.0/lib:/builds/callumdryden/gitlab-ce/vendor/ruby/2.3.0/gems/rspec-support-3.5.0/lib /builds/callumdryden/gitlab-ce/vendor/ruby/2.3.0/gems/rspec-core-3.5.0/exe/rspec --pattern spec/javascripts/fixtures/\*.rb --format documentation failed
ERROR: Build failed: exit code 1